[KYLIN-2907] Check if a number is a positive integer

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Duplicate
• Affects Version/s: v2.1.0
• Fix Version/s: v2.3.0
• Component/s: Tools, Build and Test
• Labels: newbie patch scope
• Environment: centos64
• Flags: Patch
• Assignee: Wang, Gang
• Reporter: hedong.wang
• Created: 26/Sep/17 09:50
• Updated: 02/Apr/18 13:42
• Resolved: 24/Jan/18 10:56

Description

The function isPositiveShort does not seem correct, located in the core-common/src/main/java/org/apache/kylin/common/util/BytesUtil.java.
0xFFFF7000 should be 0xFFFF8000?!
code:
public static boolean isPositiveShort(int i) {
return (i & 0xFFFF7000) == 0;
}

Issue Links

• Blocked: KYLIN-2956 building trie dictionary blocked on value of length over 4095