[KYLIN-2612] Potential NPE accessing familyMap in AclTableMigrationTool#getAllAceInfo

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: v2.1.0
• Labels: newbie scope
• Assignee: Shao Feng Shi
• Reporter: Ted Yu
• Created: 12/May/17 19:03
• Updated: 17/Aug/17 15:03
• Resolved: 22/Jul/17 14:06

Description

Here is related code:

        NavigableMap<byte[], byte[]> familyMap = result.getFamilyMap(Bytes.toBytes(AclHBaseStorage.ACL_ACES_FAMILY));
        for (Map.Entry<byte[], byte[]> entry : familyMap.entrySet()) {

Good practice is to check whether familyMap is null / empty first.

See the following class in hbase for example:
hbase-client/src/main/java/org/apache/hadoop/hbase/quotas/QuotaTableUtil.java