[KYLIN-1788] Allow arbitrary number of mandatory dimensions in one aggregation group

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: v1.5.2
• Fix Version/s: v1.5.3
• Assignee: Hongbin Ma
• Reporter: Hongbin Ma
• Created: 15/Jun/16 13:56
• Updated: 28/Jul/16 06:48
• Resolved: 21/Jul/16 07:36

Description

To prevent one aggregation group containing too many combinations we apply a check

if (mandatoryDims.size() + normalDimSize + hierarchySize + jointSize > maxSize) {
                context.addResult(ResultLevel.ERROR, "Aggregation group " + index + " has too many dimensions");
                continue;
            }

however the formular fails to take into account the case where there're many mandatory dimensions. For example, if we have 50 dimensions in a cube and we only need the base cuboid, then what we want is a single aggregation group containing all the dimensions, each of them being a mandatory.

since mandatory dimensions are more "encouraged", I suggest to remove counting mandatory dimensions in the formula. the revised code will be:

if (normalDimSize + hierarchySize + jointSize > maxSize) {
                context.addResult(ResultLevel.ERROR, "Aggregation group " + index + " has too many dimensions");
                continue;
            }

Issue Links

• is related to: KYLIN-1785 NoSuchElementException when Mandatory Dimensions contains all Dimensions