[KUDU-3067] Inexplict cloud detection for AWS and OpenStack based cloud by querying metadata

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 1.12.0
• Code Review: http://gerrit.cloudera.org:8080/15488
• Assignee: Alexey Serbin
• Reporter: liusheng
• Created: 03/Mar/20 07:05
• Updated: 19/Mar/20 16:10
• Resolved: 19/Mar/20 16:10

Description

The cloud detector is used to check the cloud provider of the instance, see here],  For AWS cloud it using the URL http://169.254.169.254/latest/meta-data/instance-id to check the specific metadata to determine it is AWS instance. This is OK, but for OpenStack based cloud, the metadata is same with AWS, so this URL can also be accessed. So this cannot distinct the AWS and other OpenStack based clouds. This caused an issue when run "HybridClockTest.TimeSourceAutoSelection" test case, this test will use the above URL to detect the Cloud of instance current running on and then try to call the NTP service, for AWS, the dedicated NTP service is "169.254.169.123", but for OpenStack based cloud, there isn't such a dedicated NTP service. So this test case will fail if I run on a instance of OpenStack based cloud because the cloud detector suppose it is AWS instance and try to access "169.254.169.123".