[KUDU-3013] Race in StopTabletITest.TestStoppedTabletsDontWrite

• Type: Bug
• Status: Open
• Priority: Major
• Resolution: Unresolved
• Component/s: test
• Assignee: Unassigned
• Reporter: LiFu He
• Created: 02/Dec/19 11:51
• Updated: 03/Jun/20 15:56

Description

I met this issue on Jenkins this morning, and it seems there is a race in StopTabletITest.TestStoppedTabletsDontWrite.

// code placeholder
TransactionDriver::ApplyTask()                            Tablet::Stop()
          |                                                     |
  transaction_->Apply()                                         |
          |                                                     |
tablet->ApplyRowOperations(state())                             |
(RESERVED -> APPLYING)                                          |
          |                                                     |
 StartApplying(tx_state);                                       |
          |                                          set_state_unlocked(kStopped);
  ApplyRowOperation()                                           |
          |                                                     |
CheckHasNotBeenStoppedUnlocked()                                |
(return error since the tablet has been stopped)                |
          |                                                     |
    HandleFailure(s)                                            |
          |                                                     |
transaction_->Finish(Transaction::ABORTED);                     |
          |                                                     |
state()->CommitOrAbort(result);                                 |
          |                                                     |
ReleaseMvccTxn(result);                                         |
          |                                                     |
mvcc_tx_->Abort();                                              |
          |                                                     |
manager_->AbortTransaction(timestamp_);                         |
          |                                                     |
if (PREDICT_FALSE(!is_open()))                                  |
          |                                                 mvcc_.Close();
          |                                                     |
          |                                               open_.store(false);
CHECK_EQ(old_state, RESERVED)                                   |
   (ASSERT failed)