Uploaded image for project: 'Kudu'
  1. Kudu
  2. KUDU-2365

Gradle-built Java artifacts aren't as well shaded as Maven-built ones

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • 1.7.0
    • 1.8.0
    • java
    • None

    Description

      If you uncomment the exclusion of "build/" from build-support/verify_jars.pl and run it after building the Java artifacts via Gradle, it raises a number of errors that don't exist in the Maven-built artifacts. For example:

      > ./kudu-spark/build/libs/kudu-spark2_2.11-1.8.0-SNAPSHOT.jar
      NON_KUDU org/slf4j/event/EventConstants.class
      NON_KUDU org/slf4j/event/EventRecodingLogger.class
      NON_KUDU org/slf4j/event/Level.class
      NON_KUDU org/slf4j/event/LoggingEvent.class
      NON_KUDU org/slf4j/event/SubstituteLoggingEvent.class
      NON_KUDU org/slf4j/helpers/BasicMarker.class
      NON_KUDU org/slf4j/helpers/BasicMarkerFactory.class
      NON_KUDU org/slf4j/helpers/BasicMDCAdapter$1.class
      NON_KUDU org/slf4j/helpers/BasicMDCAdapter.class
      NON_KUDU org/slf4j/helpers/FormattingTuple.class
      NON_KUDU org/slf4j/helpers/MarkerIgnoringBase.class
      NON_KUDU org/slf4j/helpers/MessageFormatter.class
      NON_KUDU org/slf4j/helpers/NamedLoggerBase.class
      NON_KUDU org/slf4j/helpers/NOPLogger.class
      NON_KUDU org/slf4j/helpers/NOPLoggerFactory.class
      NON_KUDU org/slf4j/helpers/NOPMDCAdapter.class
      NON_KUDU org/slf4j/helpers/SubstituteLogger.class
      NON_KUDU org/slf4j/helpers/SubstituteLoggerFactory.class
      NON_KUDU org/slf4j/helpers/Util$1.class
      NON_KUDU org/slf4j/helpers/Util$ClassContextSecurityManager.class
      NON_KUDU org/slf4j/helpers/Util.class
      NON_KUDU org/slf4j/ILoggerFactory.class
      NON_KUDU org/slf4j/IMarkerFactory.class
      NON_KUDU org/slf4j/Logger.class
      NON_KUDU org/slf4j/LoggerFactory.class
      NON_KUDU org/slf4j/Marker.class
      NON_KUDU org/slf4j/MarkerFactory.class
      NON_KUDU org/slf4j/MDC$1.class
      NON_KUDU org/slf4j/MDC$MDCCloseable.class
      NON_KUDU org/slf4j/MDC.class
      NON_KUDU org/slf4j/spi/LocationAwareLogger.class
      NON_KUDU org/slf4j/spi/LoggerFactoryBinder.class
      NON_KUDU org/slf4j/spi/MarkerFactoryBinder.class
      NON_KUDU org/slf4j/spi/MDCAdapter.class
      

      We shouldn't publish any Gradle-built artifacts until these errors are sorted out.

      Attachments

        Issue Links

          Activity

            People

              granthenke Grant Henke
              adar Adar Dembo
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: