Uploaded image for project: 'Kudu'
  1. Kudu
  2. KUDU-2134

Defer block transaction commit to the end of a tablet copy

    XMLWordPrintableJSON

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 1.5.0
    • Fix Version/s: 1.6.0
    • Component/s: tserver
    • Labels:
      None

      Description

      While looking at KUDU-2131, it occurred to me that we could solve the "batched fsyncs could lead to a tablet copy session timeout" problem entirely if we simply deferred the commit of the blocks until after we're done with the session. That would mean deferring it until after DownloadWALs. That's probably a good thing to do anyway:

      1. If DownloadWALs fails there's no reason to pay the fsync price and commit all those blocks.
      2. While DownloadWALs is running the kernel has more time to eagerly flush the blocks, so the fsyncs at the end could be cheaper.

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                hahao Hao Hao
                Reporter:
                adar Adar Dembo
              • Votes:
                0 Vote for this issue
                Watchers:
                1 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: