[KUDU-1982] Java client calls NetworkInterface.getByInetAddress too often

• Type: Bug
• Status: Resolved
• Priority: Critical
• Resolution: Fixed
• Affects Version/s: 1.1.0, 1.2.0, 1.3.0
• Fix Version/s: 1.4.0
• Component/s: client, java, perf
• Assignee: Pavel Martynov
• Reporter: Todd Lipcon
• Created: 25/Apr/17 19:57
• Updated: 27/Apr/17 21:27
• Resolved: 27/Apr/17 21:27

Description

Pavel Martynov found that the performance of the Java client on his Windows system regressed ~20x between 1.0.1 and 1.1.0 due to frequent calls to NetworkInterface.getByInetAddress. This function is apparently very slow on Windows. We are currently computing this unnecessarily in many places, and even when we do need it, we could probably cache the set of local IPs.

It's not clear that this is as problematic on Linux, but looking at the source, it's also not entirely light-weight either.