Uploaded image for project: 'Kudu'
  1. Kudu
  2. KUDU-143

kudu-lint support to check passing shared ptrs by value

Attach filesAttach ScreenshotAdd voteVotersWatch issueWatchersCreate sub-taskLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Open
    • Minor
    • Resolution: Unresolved
    • M4
    • None
    • build
    • None

    Description

      Should add a kudu-lint rule which checks for function parameters which take shared_ptr or scoped_refptr by value – these all end up causing an extra refcount increment/decrement with no value – should always be a const reference to the shared/ref ptr instead.

      Attachments

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            Unassigned Unassigned
            tlipcon Todd Lipcon

            Dates

              Created:
              Updated:

              Issue deployment