[KNOX-867] Fix FindBugs "bad practice" issues

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 0.12.0
• Assignee: Colm O hEigeartaigh
• Reporter: Colm O hEigeartaigh
• Created: 02/Feb/17 12:49
• Updated: 28/Mar/19 14:17
• Resolved: 02/Feb/17 21:14

Description

Similar to KNOX-792, this task is to fix (some of) the "bad practice" issues identified by FindBugs in the Knox code base. The issues fixed in the attached patch are:

a) Not checking the return value of File.mkdirs()
b) Not implementing Serializable when implementing Comparator
c) A few performance regressions where keySet is used instead of entrySet
d) Using platform specific "\n" instead of "%n" in String.format
e) Not overriding hashCode when overriding equals