Uploaded image for project: 'Apache Knox'
  1. Apache Knox
  2. KNOX-867

Fix FindBugs "bad practice" issues

Attach filesAttach ScreenshotVotersWatch issueWatchersCreate sub-taskLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.12.0
    • Component/s: None
    • Labels:
      None

      Description

      Similar to KNOX-792, this task is to fix (some of) the "bad practice" issues identified by FindBugs in the Knox code base. The issues fixed in the attached patch are:

      a) Not checking the return value of File.mkdirs()
      b) Not implementing Serializable when implementing Comparator
      c) A few performance regressions where keySet is used instead of entrySet
      d) Using platform specific "\n" instead of "%n" in String.format
      e) Not overriding hashCode when overriding equals

        Attachments

          Activity

            People

            • Assignee:
              coheigea Colm O hEigeartaigh
              Reporter:
              coheigea Colm O hEigeartaigh

              Dates

              • Created:
                Updated:
                Resolved:

                Issue deployment