Details
-
Improvement
-
Status: Closed
-
Major
-
Resolution: Fixed
-
None
-
None
-
None
Description
Similar to KNOX-792, this task is to fix (some of) the "bad practice" issues identified by FindBugs in the Knox code base. The issues fixed in the attached patch are:
a) Not checking the return value of File.mkdirs()
b) Not implementing Serializable when implementing Comparator
c) A few performance regressions where keySet is used instead of entrySet
d) Using platform specific "\n" instead of "%n" in String.format
e) Not overriding hashCode when overriding equals