[KNOX-748] Fix Resource Leak in X509CertificateUtil.writeCertificateToJKS

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 0.10.0
• Component/s: Server
• Assignee: Sandeep More
• Reporter: Larry McCay
• Created: 01/Sep/16 15:19
• Updated: 28/Mar/19 14:17
• Resolved: 06/Sep/16 11:21

Description

New defect(s) Reported-by: Coverity Scan
Showing 1 of 1 defect(s)

• • CID 1361992: Exceptional resource leaks (RESOURCE_LEAK)
    /gateway-spi/src/main/java/org/apache/hadoop/gateway/services/security/impl/X509CertificateUtil.java: 299 in org.apache.hadoop.gateway.services.security.impl.X509CertificateUtil.writeCertificateToJKS(java.security.cert.Certificate, java.io.File)()

________________________________________________________________________________________________________

• • • CID 1361992: Exceptional resource leaks (RESOURCE_LEAK)
      /gateway-spi/src/main/java/org/apache/hadoop/gateway/services/security/impl/X509CertificateUtil.java: 299 in org.apache.hadoop.gateway.services.security.impl.X509CertificateUtil.writeCertificateToJKS(java.security.cert.Certificate, java.io.File)()
      293
      294 char[] password = "changeme".toCharArray();
      295 ks.load(null, password);
      296 ks.setCertificateEntry("gateway-identity", cert);
      297
      298 FileOutputStream fos = new FileOutputStream(file);
      CID 1361992: Exceptional resource leaks (RESOURCE_LEAK)
      Variable "fos" going out of scope leaks the resource it refers to.
      299 ks.store(fos, password);
      300 fos.close();
      301 }