Uploaded image for project: 'Apache Knox'
  1. Apache Knox
  2. KNOX-3025

Use newer browser features in knoxauth.js + Removal of used variables

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Open
    • Minor
    • Resolution: Unresolved
    • None
    • None
    • None
    • None

    Description

      The knoxauth.js file currently utilizes outdated and inefficient browser features. It could be optimized by leveraging newer, more efficient alternatives.

      Details:

      • Rename the 'get' function to 'getQueryParam' and implement it using URLSearchParams for clarity and efficiency.
      • Update the 'isSameOrigin' function to utilize URL instead of document.create("a") for improved performance.
      • Fully rely on window.location.replace for redirect operations to enhance efficiency and reliability.
      • Implement newer techniques in the 'login' function to achieve the desired outcome more efficiently.
      • Replace jQuery usage with native features to improve speed and reduce complexity in the codebase.
      • And more

      https://github.com/apache/knox/pull/892/

      Attachments

        Issue Links

          Activity

            People

              Unassigned Unassigned
              redyetidev Aviv Keller
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:

                Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0h
                  0h
                  Logged:
                  Time Spent - 0.5h
                  0.5h