Uploaded image for project: 'Apache Knox'
  1. Apache Knox
  2. KNOX-2022

KnoxShellTable - Introduce Schema for DataTypes of Columns

    XMLWordPrintableJSON

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.4.0
    • Component/s: KnoxShell
    • Labels:
      None

      Description

      The initial motivation for KnoxShellTable was for render tabular data to the console for representing SQL responses from KnoxLine as a simple SQL client. This didn't immediately require heterogeneous datatypes across the table. Therefore, everything is of type String in the underlying structures of the table.

      As we extend the usecases and features for this class, the need to convert the underlying type to other types for operations such as compareTo or for sorting or in the future for supporting calculations, etc has emerged and may be affecting the API design or at least the implementation.

      This JIRA represents a need to revisit either the underlying structures, adding schema as optional metadata to the cols or both. If the conversion to and from Strings as the underlying type means that we need to make design or implementation compromises that are understandable then we may want to lean toward refactoring the underlying structures.

      I do want to retain the simplicity of use however and wouldn't like to see mandatory schema as a burden for simple usecases. The fluid API design should also remain as simple and natural as possible with use of primitive types for operations. How this is handled within the implementation shouldn't affect the interface.

      For instance:

      table.filter().name("price").greaterThan(100000.00d)

      The above should be able to leverage Java's autoboxing to convert the primitive double param into a Double. Internally, we can then do whatever type of conversions are necessary based on the schema introduced here. If we can do it without conversion that would be even better.

       

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                smolnar Sandor Molnar
                Reporter:
                lmccay Larry McCay
              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0h
                  0h
                  Logged:
                  Time Spent - 1h 10m
                  1h 10m