[KNOX-1548] Improve ZooKeeperConfigurationMonitorTest to not use Thread.sleep()

• Type: Test
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 1.2.0
• Assignee: Kevin Risden
• Reporter: Kevin Risden
• Created: 01/Nov/18 17:51
• Updated: 28/Mar/19 13:57
• Resolved: 02/Nov/18 14:08

Description

Currently ZooKeeperConfigurationMonitorTest uses Thread.sleep(100). This causes periodic failures on loaded machines since the condition isn't met after 100ms. Instead we should check for a condition and timeout after some time.

[ERROR] Tests run: 1, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 0.407 s <<< FAILURE! - in org.apache.knox.gateway.topology.monitor.ZooKeeperConfigurationMonitorTest
[ERROR] testZooKeeperConfigMonitor(org.apache.knox.gateway.topology.monitor.ZooKeeperConfigurationMonitorTest)  Time elapsed: 0.327 s  <<< FAILURE!
java.lang.AssertionError
	at org.apache.knox.gateway.topology.monitor.ZooKeeperConfigurationMonitorTest.testZooKeeperConfigMonitor(ZooKeeperConfigurationMonitorTest.java:202)