Uploaded image for project: 'Apache Knox'
  1. Apache Knox
  2. KNOX-1116

Builds of src distributions result in unexpected result from gateway version API

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Closed
    • Major
    • Resolution: Fixed
    • 0.14.0
    • 1.0.0
    • Build
    • None

    Description

      When a Knox build is executed outside of a git repo (e.g., src distributions), then the build.hash property in build.properties is not populated with an actual value.

      This manifests as an unexpected response to the gateway version API:
      {
      "ServerVersion" : {
      "version" : "0.14.0",
      "hash" : "${buildNumber}"
      }

      This is due to the fact that the buildnumber-maven-plugin attempts to invoke 'git rev-parse --verify HEAD', which fails because it's not in a git repo.

      This plugin apparently has a facility for specifying an alternate value when an scm error is encountered. It would be nice if Knox could employ that facility to provide a better value than ${buildNumber} in these cases.

      Attachments

        1. KNOX-1116.patch
          0.5 kB
          Colm O hEigeartaigh

        Activity

          People

            coheigea Colm O hEigeartaigh
            pzampino Philip Zampino
            Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: