[KARAF-985] LDAPLoginModule generates a large number of DirContext objects

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 2.2.4
• Fix Version/s: 2.2.5, 3.0.0
• Component/s: karaf

Environment

Karaf 2.2.5-snapshot

• Assignee: Jean-Baptiste Onofré
• Reporter: metatech
• Created: 07/Nov/11 14:15
• Updated: 13/Sep/18 19:00
• Resolved: 25/Nov/11 16:24

Description

In class org.apache.karaf.jaas.modules.ldap.LDAPLoginModule, "DirContext.close()" and "NamingEnumeration.close()" are not called in all cases.
Although it is not mandatory, it would be better to call it in all cases (to be sure, in a "finally" block).
http://download.oracle.com/javase/tutorial/jndi/ldap/close.html
Otherwise, this leaves one "com.sun.jndi.ldap.Connection" thread running for each LDAP request. After several minutes, the thread disappears automatically.
During a performance test with 10 concurrent users, this creates up to several hundreds of such threads.