Karaf
  1. Karaf
  2. KARAF-969

Feature installer should not accept different features with equal names

    Details

      Description

      The feature installer should reject feature files that contain features with conflicting names. The installer currently allows this, while the install command cannot differentiate between two features with the same name.

      Maybe the concept of feature namespaces would be a good solution. The feature repository name could function as the namespace. The install command should then support something like this:

      features:install <repo>:<feature>
      

        Activity

        Hide
        Jamie goodyear added a comment -

        Bumping to 2.2.10

        Show
        Jamie goodyear added a comment - Bumping to 2.2.10
        Hide
        Jamie goodyear added a comment -

        Bumping to 2.2.7.

        Show
        Jamie goodyear added a comment - Bumping to 2.2.7.
        Hide
        Jamie goodyear added a comment -

        Bumping to 2.2.6.

        Show
        Jamie goodyear added a comment - Bumping to 2.2.6.
        Hide
        Jean-Baptiste Onofré added a comment -

        I don't thank that using a fully qualified name will help.

        An user can still define the same feature name (even if it's full qualified) in two different features XML.

        In the feature validation util, we can check if a feature with the same name AND version exists. If it's the case, we should raise an exception.

        I'm not in favor of using features:install <repo>:<feature> because the user shouldn't take care of the repo itself.

        Show
        Jean-Baptiste Onofré added a comment - I don't thank that using a fully qualified name will help. An user can still define the same feature name (even if it's full qualified) in two different features XML. In the feature validation util, we can check if a feature with the same name AND version exists. If it's the case, we should raise an exception. I'm not in favor of using features:install <repo>:<feature> because the user shouldn't take care of the repo itself.
        Hide
        David Jencks added a comment -

        In trunk it is very easy to package the same feature into multiple feature repositories. I don't think there's anything wrong with this. I think the obvious solution is to have "fully qualified" feature names that look like what everyone is using for bundle symbolic names, e.g. org.apache.karaf.feature.MyFeatureName. I know these got removed from trunk, but IMO this jira is an example of why they should be put back.

        Show
        David Jencks added a comment - In trunk it is very easy to package the same feature into multiple feature repositories. I don't think there's anything wrong with this. I think the obvious solution is to have "fully qualified" feature names that look like what everyone is using for bundle symbolic names, e.g. org.apache.karaf.feature.MyFeatureName. I know these got removed from trunk, but IMO this jira is an example of why they should be put back.

          People

          • Assignee:
            Unassigned
            Reporter:
            Geert Schuring
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:

              Development