Karaf
  1. Karaf
  2. KARAF-819

Rename Karaf features name (and sub-projects features name) to use full qualified name

    Details

      Description

      Our feature names are quite short (e.g. "jndi") and it seems to me this is likely to cause confusion when features get more widely adopted.

      The features name should be changed to use a full qualified name (as a Felix or Karaf symbolic names best practice) eg. "org.apache.karaf.feature.jndi"

        Issue Links

          Activity

          Hide
          Jean-Baptiste Onofré added a comment -

          For now, I close this Jira, it will be re-open after discussion on the mailing list.

          Show
          Jean-Baptiste Onofré added a comment - For now, I close this Jira, it will be re-open after discussion on the mailing list.
          Hide
          Jean-Baptiste Onofré added a comment -

          Rollback done: revision 1182967.

          Show
          Jean-Baptiste Onofré added a comment - Rollback done: revision 1182967.
          Hide
          Jean-Baptiste Onofré added a comment -

          The result doesn't convince. For now, I'm reverting this change. If some feature names are ambiguous, we will change it. We can also discuss about a feature naming convention.

          Show
          Jean-Baptiste Onofré added a comment - The result doesn't convince. For now, I'm reverting this change. If some feature names are ambiguous, we will change it. We can also discuss about a feature naming convention.
          Hide
          Jean-Baptiste Onofré added a comment -

          I close this Jira. Now, if they want, others projects (Camel, CXF, SMX, etc) can change their features to use a FQN.

          Show
          Jean-Baptiste Onofré added a comment - I close this Jira. Now, if they want, others projects (Camel, CXF, SMX, etc) can change their features to use a FQN.
          Hide
          Jean-Baptiste Onofré added a comment -

          Cellar trunk now uses full qualified features name (including "old" name aliases): revision 1178713.

          Show
          Jean-Baptiste Onofré added a comment - Cellar trunk now uses full qualified features name (including "old" name aliases): revision 1178713.
          Hide
          Jean-Baptiste Onofré added a comment -

          For consistency, I renamed the feature in name by features (revision 1178708).

          Show
          Jean-Baptiste Onofré added a comment - For consistency, I renamed the feature in name by features (revision 1178708).
          Hide
          Jean-Baptiste Onofré added a comment -

          Added features aliases to the "old" names (revision 1178422).

          Show
          Jean-Baptiste Onofré added a comment - Added features aliases to the "old" names (revision 1178422).
          Hide
          Jean-Baptiste Onofré added a comment -

          For transition purpose, I'm adding features aliases to the "old" names.

          Show
          Jean-Baptiste Onofré added a comment - For transition purpose, I'm adding features aliases to the "old" names.
          Hide
          David Jencks added a comment -

          I renamed the features to include "standard", "enterprise", etc. as you suggested. AFAICT this commit is complete, but then i thought the previous one was too.

          Show
          David Jencks added a comment - I renamed the features to include "standard", "enterprise", etc. as you suggested. AFAICT this commit is complete, but then i thought the previous one was too.
          Hide
          Jean-Baptiste Onofré added a comment -

          I fixed the default assembly (apache-karaf): revision 1162313.

          A bunch of modules have to be updated (maven plugin, others assemblies, itests).

          @David, please, next time, do not perform an "incomplete" commit. I think that a commit should be atomic and fully tested. Thanks

          Show
          Jean-Baptiste Onofré added a comment - I fixed the default assembly (apache-karaf): revision 1162313. A bunch of modules have to be updated (maven plugin, others assemblies, itests). @David, please, next time, do not perform an "incomplete" commit. I think that a commit should be atomic and fully tested. Thanks
          Hide
          Jean-Baptiste Onofré added a comment -

          Only change the name in the features descriptor is not enough. We have also to change others files, like the etc/org.apache.karaf.features.cfg around the bootFeatures.

          I'm gonna fix it on trunk, as now it's inconsistent.

          Show
          Jean-Baptiste Onofré added a comment - Only change the name in the features descriptor is not enough. We have also to change others files, like the etc/org.apache.karaf.features.cfg around the bootFeatures. I'm gonna fix it on trunk, as now it's inconsistent.
          Hide
          Jean-Baptiste Onofré added a comment -

          I guess that we should propose to the others projects to update their features name also. For instance, org.apache.camel.core, org.apache.camel.http, org.apache.cxf, etc.

          WDYT ?

          Show
          Jean-Baptiste Onofré added a comment - I guess that we should propose to the others projects to update their features name also. For instance, org.apache.camel.core, org.apache.camel.http, org.apache.cxf, etc. WDYT ?
          Hide
          Jean-Baptiste Onofré added a comment -

          I was expecting org.apache.karaf.feature.standard.http, more than org.apache.karaf.feature.http to contain the full qualified name.

          Show
          Jean-Baptiste Onofré added a comment - I was expecting org.apache.karaf.feature.standard.http, more than org.apache.karaf.feature.http to contain the full qualified name.
          Hide
          Jean-Baptiste Onofré added a comment -

          Thanks David.

          There are several project that reference Karaf features (in CXF, Camel, ServiceMix, etc).

          For now, these projects use Karaf 2.2.x branch, so it's not a big deal.

          I'm gonna update the sub-projects also.

          Show
          Jean-Baptiste Onofré added a comment - Thanks David. There are several project that reference Karaf features (in CXF, Camel, ServiceMix, etc). For now, these projects use Karaf 2.2.x branch, so it's not a big deal. I'm gonna update the sub-projects also.
          Hide
          David Jencks added a comment -

          I had a few minutes so I changed the names in karaf, rev 1160118. Are the names used in other subprojects e.g. cellar, cave, etc?

          I noticed the feature names now look a lot like the symbolic names for the feature implementation bundles,

          org.apache.karaf.feature.obr (feature)

          org.apache.karaf.features.core (bundle)

          The feature projects are currently located under assemblies so we might consider

          org.apache.karaf.assemblies.feature.obr

          although I'm fine with the shorter names I used.

          Show
          David Jencks added a comment - I had a few minutes so I changed the names in karaf, rev 1160118. Are the names used in other subprojects e.g. cellar, cave, etc? I noticed the feature names now look a lot like the symbolic names for the feature implementation bundles, org.apache.karaf.feature.obr (feature) org.apache.karaf.features.core (bundle) The feature projects are currently located under assemblies so we might consider org.apache.karaf.assemblies.feature.obr although I'm fine with the shorter names I used.

            People

            • Assignee:
              Jean-Baptiste Onofré
              Reporter:
              Jean-Baptiste Onofré
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development