Karaf
  1. Karaf
  2. KARAF-778

karaf does not work properly with spaces in the working directory path

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Blocker Blocker
    • Resolution: Not a Problem
    • Affects Version/s: 2.2.2
    • Fix Version/s: None
    • Component/s: None
    • Labels:
      None
    • Environment:

      Windows XP (Virtualbox) with sun-java "1.6.0_24" and Ubuntu 11.04 with sun-java "1.6.0_26"

      Description

      • Create two directories: "nospace" and "with space" (and make sure the path does not contain any other spaces)
      • download karaf-2.2.2 and extract a copy into each directory.
      • executing nospace/karaf/bin/karaf works just fine
        karaf@root> features:listurl
         Loaded   URI
          true    mvn:org.apache.karaf.assemblies.features/standard/2.2.2/xml/features
          true    mvn:org.apache.karaf.assemblies.features/enterprise/2.2.2/xml/features
        
      • executing with space/karaf/bin/karaf does not work
        karaf@root> features:listurl
         Loaded   URI
        No repository URLs are set.
        

        It seems that the featres.cfg is not read at all when the path contains a space.

      Adding a URI manually also does not work:

      karaf@root> features:addurl mvn:org.apache.karaf.assemblies.features/standard/2.
      2.2/xml/features
      Could not add Feature Repository:
      java.net.MalformedURLException: Illegal character in path at index 31: file:/home/christophg/test/with space/apache-karaf-2.2.2/system/
      

        Issue Links

          Activity

          Hide
          Andreas Pieber added a comment -

          ok, the base problem is located in pax-url. I've already located and fixed the problem. I'll create the issue at pax-url, release it and upgrade Karaf. Integration tests still fail in the folder. I'm looking into it

          Show
          Andreas Pieber added a comment - ok, the base problem is located in pax-url. I've already located and fixed the problem. I'll create the issue at pax-url, release it and upgrade Karaf. Integration tests still fail in the folder. I'm looking into it
          Hide
          Andreas Pieber added a comment -

          Committing to https://svn.apache.org/repos/asf/karaf/branches/karaf-2.2.x ...
          M admin/core/src/test/java/org/apache/karaf/jpm/ProcessTest.java
          M assemblies/apache-karaf/src/main/distribution/unix-shell/bin/karaf
          M assemblies/apache-karaf/src/main/distribution/unix-shell/bin/start
          M assemblies/apache-karaf/src/main/distribution/unix-shell/bin/stop
          M deployer/kar/src/test/java/org/apache/karaf/deployer/kar/KarArtifactInstallerTest.java
          M main/src/test/java/org/apache/karaf/main/MainStartTest.java
          Committed r1151893

          OK, lets see what have to be done for the master and check if windows works

          Show
          Andreas Pieber added a comment - Committing to https://svn.apache.org/repos/asf/karaf/branches/karaf-2.2.x ... M admin/core/src/test/java/org/apache/karaf/jpm/ProcessTest.java M assemblies/apache-karaf/src/main/distribution/unix-shell/bin/karaf M assemblies/apache-karaf/src/main/distribution/unix-shell/bin/start M assemblies/apache-karaf/src/main/distribution/unix-shell/bin/stop M deployer/kar/src/test/java/org/apache/karaf/deployer/kar/KarArtifactInstallerTest.java M main/src/test/java/org/apache/karaf/main/MainStartTest.java Committed r1151893 OK, lets see what have to be done for the master and check if windows works
          Hide
          Michael Van Geertruy added a comment -

          Confirmed the bug in the 2.2.2 release. Also, confirmed the Pieber's fix in 2.2.3.

          Show
          Michael Van Geertruy added a comment - Confirmed the bug in the 2.2.2 release. Also, confirmed the Pieber's fix in 2.2.3.
          Hide
          Michael Van Geertruy added a comment -

          Also confirmed that this is NOT an issue on the trunk (phew!). The OS this was tested with was: Windows 7 Home Premium 64 bit. As long as this works with XP Pro and Vista, I suggest we mark this ticket as closed.

          Show
          Michael Van Geertruy added a comment - Also confirmed that this is NOT an issue on the trunk (phew!). The OS this was tested with was: Windows 7 Home Premium 64 bit. As long as this works with XP Pro and Vista, I suggest we mark this ticket as closed.
          Hide
          Andreas Pieber added a comment -

          While Christoph's usecase works on 2.2.3 (after my upgrades) karaf still does not build on windows if you build it in a "kar af" folder on windows. Can you confirm this Mike?

          @master: this surprises me. The bug is basically a problem of paxurl and it was on all paxurl versions. I've not upgrade paxurl/paxrunner on the master by now. Did we change anything in the url resolving process here on the master? Also we have to verify if it builds using a space in the name.

          While this issue may be fixed I'm not convinced that we've caught all space-path-problems. One general trick here: If you get a URL in form of a String new File(new URI(pathAsString).getPath) have to be used everywhere. Otherwise %20 and other special url characters results in problems in Karaf...

          Show
          Andreas Pieber added a comment - While Christoph's usecase works on 2.2.3 (after my upgrades) karaf still does not build on windows if you build it in a "kar af" folder on windows. Can you confirm this Mike? @master: this surprises me. The bug is basically a problem of paxurl and it was on all paxurl versions. I've not upgrade paxurl/paxrunner on the master by now. Did we change anything in the url resolving process here on the master? Also we have to verify if it builds using a space in the name. While this issue may be fixed I'm not convinced that we've caught all space-path-problems. One general trick here: If you get a URL in form of a String new File(new URI(pathAsString).getPath) have to be used everywhere. Otherwise %20 and other special url characters results in problems in Karaf...
          Hide
          Andreas Pieber added a comment -

          At least no longer a problem; this had been fixed somewhere with an pax-url upgrade

          Show
          Andreas Pieber added a comment - At least no longer a problem; this had been fixed somewhere with an pax-url upgrade

            People

            • Assignee:
              Andreas Pieber
              Reporter:
              Christoph Gritschenberger
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development