[KARAF-643] KarArtifactInstaller::init has incorrect warning logic

• Type: Bug
• Status: Closed
• Priority: Trivial
• Resolution: Fixed
• Affects Version/s: 2.2.0, 2.2.1
• Fix Version/s: 2.2.9, 2.3.0
• Component/s: karaf

Environment

Ubuntu Linux (though I believe the issue affects all platforms).

• Assignee: Freeman Yue Fang
• Reporter: Yaytay
• Created: 16/May/11 13:28
• Updated: 15/Sep/18 05:04
• Resolved: 13/Aug/12 00:54

Description

KarArtifactInstaller.java has the following block:
if (new File(timestampPath).mkdirs()) {
logger.warn("Unable to create directory for Karaf Archive timestamps. Results may vary...");
}

which looks as though it's missing a !
mkdirs returns true if and only if the directory was created, along with all necessary parent directories; false otherwise.