[KARAF-6238] org.apache.karaf.profile.assembly.Builder#downloadLibraries is not synchronized

• Type: Bug
• Status: Resolved
• Priority: Blocker
• Resolution: Fixed
• Affects Version/s: 4.2.4
• Fix Version/s: 4.3.0, 4.2.5
• Assignee: Grzegorz Grzybek
• Reporter: Grzegorz Grzybek
• Created: 15/Apr/19 09:54
• Updated: 15/Apr/19 11:10
• Resolved: 15/Apr/19 11:10

Description

I had strange case. Running:

for n in {1..100}; do
    mvn clean install -DskipTests -f /path/to/custom-karaf-distro
    cp /path/to/custom-karaf-distro/target/assembly/etc/config.properties /data/tmp/config-$n.properties
    cat /path/to/custom-karaf-distro/target/assembly/etc/config.properties | sort > /data/tmp/config-$n-sorted.properties
done

I was usually getting the same config.propertie. But not always. Occasionally some extra packages were missing...

Long story short, downloader uses 8 threads and org.apache.karaf.profile.assembly.Builder#downloadLibraries() uses the download callback without any synchronization...