[KARAF-5173] Some tests could benefit from a common CallbackHandler

• Type: Improvement
• Status: Resolved
• Priority: Trivial
• Resolution: Fixed
• Affects Version/s: 4.2.0.M1
• Fix Version/s: 4.2.0.M1
• Component/s: karaf
• Assignee: Jean-Baptiste Onofré
• Reporter: Stephen Kitt
• Created: 01/Jun/17 14:55
• Updated: 14/Sep/18 08:35
• Resolved: 02/Jun/17 11:05

Description

I’ve noticed that a number of tests contain code like

        CallbackHandler cb = new CallbackHandler() {
            public void handle(Callback[] callbacks) throws IOException, UnsupportedCallbackException {
                for (Callback cb : callbacks) {
                    if (cb instanceof NameCallback) {
                        ((NameCallback) cb).setName("hnelson");
                    } else if (cb instanceof PasswordCallback) {
                        ((PasswordCallback) cb).setPassword("secret".toCharArray());
                    }
                }
            }
        };

It might make sense to introduce a concrete implementation of CallbackHandler to provide this.

Issue Links

• links to: GitHub Pull Request #310