[KARAF-5123] Executing feature:repo-remove can leave karaf in an invalid state

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 4.1.1
• Fix Version/s: 4.1.2, 4.2.0.M1
• Component/s: karaf
• Assignee: Guillaume Nodet
• Reporter: Christian Schneider
• Created: 12/May/17 07:57
• Updated: 14/Sep/18 15:14
• Resolved: 29/Jun/17 08:10

Description

To reproduce:

feature:repo-add activemq 5.14.5
feature:install activemq-client
feature:repo-remove activemq-5.14.5

After this step karaf is in an invalid state but no error / warning is shown

feature:install jdbc

Error executing command: Unable to resolve root: missing requirement [root] osgi.identity; osgi.identity=activemq-client; type=karaf.feature; version="[5.14.5,5.14.5]"; filter:="(&(osgi.identity=activemq-client)(type=karaf.feature)(version>=5.14.5)(version<=5.14.5))"

When installing any other feature karaf complains about the feature activemq-client as it knowns it should be installed but does not find the repo anymore.

The workaround is to remove all features that are now not available anymore in one step. Removing individually does not work if there are more than one feature missing as feature:uninstall is only executed if it leaves karaf in a valid state.

I propose we these things:

• At least we need to provide a warning when executing feature:repo-remove and list all features that are now unavailable.
• Even better would be to refuse to remove the repo when some of its features are still needed. Eventually we want an override like -f to force removal.

Issue Links

• is related to: KARAF-4060 Throw an error when removing a repo containing installed features
• links to: GitHub Pull Request #300