[KARAF-4724] bin/client CLASSPATH is hardcoded

• Type: Improvement
• Status: Resolved
• Priority: Major
• Resolution: Not A Problem
• Affects Version/s: 4.0.6
• Component/s: karaf
• Assignee: Jean-Baptiste Onofré
• Reporter: Yurii Rashkovskii
• Created: 22/Sep/16 01:35
• Updated: 13/Jan/20 17:36
• Resolved: 13/Jan/20 17:36

Description

As per discussion on IRC, in certain cases it would make sense to add bouncycastle to an assembled karaf distribution. Following manual, everything is ok on the container's side (although it would have been nice if it was simpler), but this doesn't work well with the client (bin/client) as its classpath is hardcoded: https://github.com/apache/karaf/blob/karaf-4.0.6/assemblies/features/base/src/main/filtered-resources/resources/bin/client#L272-L276

Without seeing BC classes, this is what client produces:

Error starting ssh agent for: org/bouncycastle/openssl/PEMParser
Logging in as karaf
362 [sshd-SshClient[a4102b8]-nio2-thread-2] WARN org.apache.sshd.client.keyverifier.AcceptAllServerKeyVerifier - Server at /0.0.0.0:8101 presented unverified RSA key: 52:37:d6:79:06:dc:98:73:41:94:4c:13:88:08:c0:4b
367 [sshd-SshClient[a4102b8]-nio2-thread-3] WARN org.apache.sshd.client.session.ClientSessionImpl - Exception caught
java.lang.NullPointerException
	at org.apache.sshd.agent.common.AgentDelegate.getIdentities(AgentDelegate.java:40)
	at org.apache.sshd.client.auth.UserAuthPublicKey.init(UserAuthPublicKey.java:79)
	at org.apache.sshd.client.session.ClientUserAuthServiceNew.tryNext(ClientUserAuthServiceNew.java:212)
	at org.apache.sshd.client.session.ClientUserAuthServiceNew.processUserAuth(ClientUserAuthServiceNew.java:178)

Suggestion: scan files in lib (lib/*/.jar or something) and add them all to bin/client.

Thoughts?