[KARAF-4519] If an action does not have a @Command annotation, fallback to calling a description() method via reflection to get an Action's description

• Type: Bug
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 4.0.5
• Fix Version/s: 4.1.0, 4.0.6
• Assignee: Jean-Baptiste Onofré
• Reporter: Luca Burgazzoli
• Created: 05/May/16 15:23
• Updated: 24/Jun/16 05:25
• Resolved: 24/Jun/16 05:25

Description

Commands descriptions for ActiveMQ 5.x can't be retrieved by Karaf when using help command as the services exported by ActiveMQ do not provide such information so Karaf fallback to command name as description which is not very useful.

An enhancement has been added to ActiveMQ: https://github.com/apache/activemq/commit/7fd5fa9253deb3a2815cb375b85731a959ad3845

CommandTracker should be enhanced to try to invoke description method if standard methods are not available (i.e. Command annotation not present).

I will provide a PR

before:

activemq:browse                   browse
activemq:bstat                    bstat
activemq:consumer                 consumer
activemq:dstat                    dstat
activemq:list                     list
activemq:producer                 producer
activemq:purge                    purge
activemq:query                    query

after:

activemq:browse                   Display selected messages in a specified destination.
activemq:bstat                    Performs a predefined query that displays useful statistics regarding the specified broker
activemq:consumer                 Receives messages from the broker
activemq:dstat                    Performs a predefined query that displays useful tabular statistics regarding the specified destination type
activemq:list                     Lists all available brokers in the specified JMX context
activemq:producer                 Sends messages to the broker
activemq:purge                    Delete selected destination's messages that matches the message selector
activemq:query                    Display selected broker component's attributes and statistics.

Issue Links

• links to: GitHub Pull Request #181