[KARAF-4475] Performing status check will wipe cache if karaf.clean.all/karaf.clean.cache is set

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 4.1.0, 4.0.5
• Component/s: karaf
• Assignee: Jean-Baptiste Onofré
• Reporter: Fabian Lange
• Created: 06/Apr/16 16:06
• Updated: 14/Sep/18 08:36
• Resolved: 10/Apr/16 08:28

Description

Whenever somebody does "new ConfigProperties()" the cache files are deleted:
https://github.com/apache/karaf/blob/master/main/src/main/java/org/apache/karaf/main/ConfigProperties.java#L181

This is problematic, as with a running karaf instance, somebody who will invoke the status script, will wipe the cache directory of the running instance, resulting in various problems

Both: Status and Stop are guilty of doing that.
https://github.com/apache/karaf/blob/b8c2617c278bb899c0af2ea1a8d2dc987f22f1cb/main/src/main/java/org/apache/karaf/main/Status.java#L38
https://github.com/apache/karaf/blob/b8c2617c278bb899c0af2ea1a8d2dc987f22f1cb/main/src/main/java/org/apache/karaf/main/Stop.java#L42

I propose to move the deletion logic to Main.launch()
https://github.com/apache/karaf/blob/b8c2617c278bb899c0af2ea1a8d2dc987f22f1cb/main/src/main/java/org/apache/karaf/main/Main.java#L230

Issue Links

• is duplicated by: KARAF-4156 Set 'karaf.clean.all' as true will cause data folder cleaned while checking status
• relates to: KARAF-4819 System Property karaf.clean.all Doesn't Work