Karaf
  1. Karaf
  2. KARAF-445

Add completion for shell aliases

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 2.2.1
    • Fix Version/s: 2.2.2, 3.0.0
    • Component/s: karaf-shell
    • Labels:
      None

      Description

      When users define aliases in etc/shell.init.script, such as:

      my-feature:install

      { features:install my-feature }

      ;

      in the shell, there are not completer for the aliases.

      It could be helpful to have a aliases completer.

      1. KARAF-445.patch
        11 kB
        Christian Schneider

        Activity

        Jean-Baptiste Onofré created issue -
        Guillaume Nodet made changes -
        Field Original Value New Value
        Fix Version/s 2.2.0 [ 12315328 ]
        Hide
        Christian Schneider added a comment -

        AliasesCompleter should be added to console/src/main/java/org/apache/karaf/shell/console/completer

        Show
        Christian Schneider added a comment - AliasesCompleter should be added to console/src/main/java/org/apache/karaf/shell/console/completer
        Hide
        Christian Schneider added a comment -

        Aliases are now expanded in tab completion. I also refactored the unproxy method and the run method of console to make them simpler / better readable

        Show
        Christian Schneider added a comment - Aliases are now expanded in tab completion. I also refactored the unproxy method and the run method of console to make them simpler / better readable
        Christian Schneider made changes -
        Attachment KARAF-445.patch [ 12480661 ]
        Ioannis Canellos made changes -
        Assignee Ioannis Canellos [ iocanel ]
        Jean-Baptiste Onofré made changes -
        Assignee Ioannis Canellos [ iocanel ] Jean-Baptiste Onofré [ jbonofre ]
        Jean-Baptiste Onofré made changes -
        Status Open [ 1 ] In Progress [ 3 ]
        Jean-Baptiste Onofré made changes -
        Affects Version/s 2.2.1 [ 12316164 ]
        Fix Version/s 2.2.2 [ 12316339 ]
        Component/s console [ 12313723 ]
        Hide
        Jean-Baptiste Onofré added a comment -

        After reviewing the patch, I'm OK with the pure aliases completer.
        However, I'm not fully agree with the unproxy refactoring especially because it doesn't use the OSGi service reference anymore.

        I apply only the aliases completion implementation (which is the first purpuse of this Jira) on both trunk and karaf-2.2.x branch.

        Show
        Jean-Baptiste Onofré added a comment - After reviewing the patch, I'm OK with the pure aliases completer. However, I'm not fully agree with the unproxy refactoring especially because it doesn't use the OSGi service reference anymore. I apply only the aliases completion implementation (which is the first purpuse of this Jira) on both trunk and karaf-2.2.x branch.
        Hide
        Jean-Baptiste Onofré added a comment -

        Fixed on trunk: revision 1128641.
        Fixed on karaf-2.2.x branch: revision 1128644.

        Show
        Jean-Baptiste Onofré added a comment - Fixed on trunk: revision 1128641. Fixed on karaf-2.2.x branch: revision 1128644.
        Jean-Baptiste Onofré made changes -
        Status In Progress [ 3 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Hide
        Jamie goodyear added a comment -

        Fixed in Apache Karaf 2.2.2.

        Show
        Jamie goodyear added a comment - Fixed in Apache Karaf 2.2.2.
        Jamie goodyear made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Transition Time In Source Status Execution Times Last Executer Last Execution Date
        Open Open In Progress In Progress
        109d 22h 27m 1 Jean-Baptiste Onofré 28/May/11 07:45
        In Progress In Progress Resolved Resolved
        6h 53m 1 Jean-Baptiste Onofré 28/May/11 14:38
        Resolved Resolved Closed Closed
        37d 5h 17m 1 Jamie goodyear 04/Jul/11 19:55

          People

          • Assignee:
            Jean-Baptiste Onofré
            Reporter:
            Jean-Baptiste Onofré
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development