[KARAF-4371] karaf shell scripts use "local" which is not a posix compliant

• Type: Bug
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 4.1.0, 4.0.5
• Component/s: karaf
• Assignee: Freeman Fang
• Reporter: Luca Burgazzoli
• Created: 29/Feb/16 16:31
• Updated: 15/Sep/18 05:24
• Resolved: 02/Mar/16 07:34

Description

karaf shell scripts use "local" in function pathCanonical which is not posix compliant:

pathCanonical() {
    local dst="${1}"
    while [ -h "${dst}" ] ; do
        ls=`ls -ld "${dst}"`
        link=`expr "$ls" : '.*-> \(.*\)$'`
        if expr "$link" : '/.*' > /dev/null; then
            dst="$link"
        else
            dst="`dirname "${dst}"`/$link"
        fi
    done
    local bas=`basename "${dst}"`
    local dir=`dirname "${dst}"`
    if [ "$bas" != "$dir" ]; then
        dst="`pathCanonical "$dir"`/$bas"
    fi
    echo "${dst}" | sed -e 's#//#/#g' -e 's#/./#/#g' -e 's#/[^/]*/../#/#g'
}

As a consequence the script fails on non-bash shells:

bin/karaf[169]: local: not found [No such file or directory]
bin/karaf[179]: local: not found [No such file or directory]
bin/karaf[180]: local: not found [No such file or directory]