[KARAF-4271] Circular dependency not handled properly when a feature references itself directly

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 4.0.4
• Fix Version/s: 4.1.0
• Component/s: karaf
• Assignee: Guillaume Nodet
• Reporter: Roland Hauser
• Created: 14/Jan/16 17:37
• Updated: 14/Sep/18 15:14
• Resolved: 20/Oct/16 20:21

Description

I did some experiments with circular dependencies where a feature references itself directly. When attribute prerequisite is set to false then the feature install succeeds with following log-message

2016-01-14 17:44:25,509 | INFO  | e user appsrvadm | FeaturesServiceImpl              | 7 - org.apache.karaf.features.core - 4.0.4 | Adding features: self-circular-dependency/[1.0.0.SNAPSHOT,1.0.0.SNAPSHOT]
2016-01-14 17:44:25,795 | INFO  | pool-47-thread-1 | FeaturesServiceImpl              | 7 - org.apache.karaf.features.core - 4.0.4 | No deployment change.
2016-01-14 17:44:25,803 | INFO  | pool-47-thread-1 | FeaturesServiceImpl              | 7 - org.apache.karaf.features.core - 4.0.4 | Done.

When prerequisite is set to true, the feature installation fails with a StackOverFlowError:

java.lang.StackOverflowError
	at org.apache.karaf.features.internal.region.Subsystem.<init>(Subsystem.java:117)
	at org.apache.karaf.features.internal.region.SubsystemResolver.prepare(SubsystemResolver.java:103)
	at org.apache.karaf.features.internal.service.Deployer.deploy(Deployer.java:218)
	at org.apache.karaf.features.internal.service.Deployer.deploy(Deployer.java:259)
	at org.apache.karaf.features.internal.service.Deployer.deploy(Deployer.java:259)
	at org.apache.karaf.features.internal.service.Deployer.deploy(Deployer.java:259)
	at org.apache.karaf.features.internal.service.Deployer.deploy(Deployer.java:259)
	at org.apache.karaf.features.internal.service.Deployer.deploy(Deployer.java:259)
	at org.apache.karaf.features.internal.service.Deployer.deploy(Deployer.java:259)
	at org.apache.karaf.features.internal.service.Deployer.deploy(Deployer.java:259)
	at org.apache.karaf.features.internal.service.Deployer.deploy(Deployer.java:259)
	at org.apache.karaf.features.internal.service.Deployer.deploy(Deployer.java:259)
	at org.apache.karaf.features.internal.service.Deployer.deploy(Deployer.java:259)
	...
	at org.apache.karaf.features.internal.service.Deployer.deploy(Deployer.java:259)
	at org.apache.karaf.features.internal.service.FeaturesServiceImpl.doProvision(FeaturesServiceImpl.java:1089)
	at org.apache.karaf.features.internal.service.FeaturesServiceImpl$1.call(FeaturesServiceImpl.java:985)
	at java.util.concurrent.FutureTask.run(FutureTask.java:266)[:1.8.0_65]
	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)[:1.8.0_65]
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)[:1.8.0_65]
	at java.lang.Thread.run(Thread.java:745)[:1.8.0_65]}}

I would expect in both cases, that the feature:install command fails with an error message like this: "Feature com.foo.bar could not be installed because it references itself"
You can checkout a project which helps to reproduce the case from https://github.com/SourcePond/reproduce-feature-circular-dependency.git (Maven-Modules self-circular-dependency and self-circular-dependency-prerequisite-true). Simply install the root-project to have all necessary Maven dependencies.

Issue Links

• relates to: KARAF-4272 Karaf freezes when a circular dependency is introduced where a feature references itself over a chain of other features