[KARAF-3964] cygpath call in "start" to convert CLASSPATH should first verify it's set

• Type: Bug
• Status: Resolved
• Priority: Trivial
• Resolution: Fixed
• Fix Version/s: 4.0.2, 3.0.6
• Component/s: karaf

Environment

Windows 7, Cygwin

• Assignee: Jean-Baptiste Onofré
• Reporter: David M. Karr
• Created: 31/Aug/15 16:32
• Updated: 14/Sep/18 08:35
• Resolved: 09/Oct/15 13:05

Description

Several of the Karaf scripts have "if $cygwin" blocks that convert some variables to Windows form. If the variable referenced is not set, cygpath will fail with "cygpath: can't convert empty path". The impact is debatable, as the variable after the command will be unset, same as before it, but the error message can be confusing for users.

Most of these cases are likely dealt with, but one that is not is in the "start" script, for the "CLASSPATH" variable. I don't set a global CLASSPATH value, and I believe it's generally a bad idea to set one.

The most reasonable fix is to simply not run cygpath if CLASSPATH is not set or is empty. Therefore, change this:

CLASSPATH=`cygpath --path --windows "$CLASSPATH"`

to:

if [ ! -z "$CLASSPATH" ]; then
CLASSPATH=`cygpath --path --windows "$CLASSPATH"`
fi