[KARAF-3798] FeaturesServiceImpl not threadsafe

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 4.0.0.M3
• Fix Version/s: 4.1.0, 4.0.6
• Component/s: karaf
• Assignee: Jean-Baptiste Onofré
• Reporter: Fabian Lange
• Created: 19/Jun/15 14:08
• Updated: 14/Sep/18 15:14
• Resolved: 26/Jun/16 05:52

Description

This error happens pretty frequently with M3, when there are multiple features installed on startup and config files to activate them created.

2015-06-19 15:55:12,249 | ERROR | 43-3aaf88a7bd8b) | configadmin                      | 3 - org.apache.felix.configadmin - 1.8.4 | Unexpected problem delivering configuration event to [org.osgi.service.cm.ConfigurationListener, id=30, bundle=9/mvn:org.apache.felix/org.apache.felix.scr/1.8.2]
java.lang.NullPointerException
	at org.apache.felix.scr.impl.config.ConfigurationSupport.configurationEvent(ConfigurationSupport.java:283)[9:org.apache.felix.scr:1.8.2]
	at org.apache.felix.cm.impl.ConfigurationManager$FireConfigurationEvent.sendEvent(ConfigurationManager.java:2036)[3:org.apache.felix.configadmin:1.8.4]
	at org.apache.felix.cm.impl.ConfigurationManager$FireConfigurationEvent.run(ConfigurationManager.java:2005)[3:org.apache.felix.configadmin:1.8.4]
	at org.apache.felix.cm.impl.UpdateThread.run(UpdateThread.java:103)[3:org.apache.felix.configadmin:1.8.4]
	at java.lang.Thread.run(Thread.java:745)[:1.8.0_40]

As written in latest comment, the root cause seems to be that multiple installFeature calls to FeatureService mess up the state of the bundles. In my case it left a bundle in a corrupt state, which was noticed when the configuration change did not really activate the service.

Issue Links

• links to: GitHub Pull Request #138