[KARAF-3683] Improve message when feature is not found

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.4.1
• Fix Version/s: 2.4.3
• Component/s: karaf
• Assignee: Jean-Baptiste Onofré
• Reporter: Jean-Baptiste Onofré
• Created: 21/Apr/15 20:26
• Updated: 15/Sep/18 16:35
• Resolved: 08/Jul/15 16:12

Description

To specify a feature with a version, we should use the name/version syntax.

When the provided feature doesn't exist, the message is not very explicit:

karaf@root> features:install hibernate/4.3.6.FINAL
Error executing command: Can't install feature hibernate/4.3.6.FINAL: 
null

The log shows:

2015-04-21 22:26:14,803 | ERROR | l Console Thread | Console                          | ?                                   ? | 17 - org.apache.karaf.shell.console - 2.4.2.SNAPSHOT | Exception caught while executing command
java.lang.IllegalStateException: Can't install feature hibernate/4.3.6.FINAL: 
null
        at org.apache.karaf.features.internal.FeaturesServiceImpl.installFeature(FeaturesServiceImpl.java:447)
        at org.apache.karaf.features.command.InstallFeatureCommand.doExecute(InstallFeatureCommand.java:67)
        at org.apache.karaf.features.command.FeaturesCommandSupport.doExecute(FeaturesCommandSupport.java:41)
        at org.apache.karaf.shell.console.OsgiCommandSupport.execute(OsgiCommandSupport.java:38)
        at org.apache.felix.gogo.commands.basic.AbstractCommand.execute(AbstractCommand.java:35)
        at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)[:1.7.0_67]
        at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)[:1.7.0_67]
        at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)[:1.7.0_67]
        at java.lang.reflect.Method.invoke(Method.java:606)[:1.7.0_67]
        at org.apache.aries.proxy.impl.ProxyHandler$1.invoke(ProxyHandler.java:54)[11:org.apache.aries.proxy.impl:1.0.4]
        at org.apache.aries.proxy.impl.ProxyHandler.invoke(ProxyHandler.java:119)[11:org.apache.aries.proxy.impl:1.0.4]
        at org.apache.karaf.shell.console.commands.$BlueprintCommand271145930.execute(Unknown Source)[17:org.apache.karaf.shell.console:2.4.2.SNAPSHOT]
        at org.apache.felix.gogo.runtime.CommandProxy.execute(CommandProxy.java:78)[17:org.apache.karaf.shell.console:2.4.2.SNAPSHOT]
        at org.apache.felix.gogo.runtime.Closure.executeCmd(Closure.java:477)[17:org.apache.karaf.shell.console:2.4.2.SNAPSHOT]
        at org.apache.felix.gogo.runtime.Closure.executeStatement(Closure.java:403)[17:org.apache.karaf.shell.console:2.4.2.SNAPSHOT]
        at org.apache.felix.gogo.runtime.Pipe.run(Pipe.java:108)[17:org.apache.karaf.shell.console:2.4.2.SNAPSHOT]
        at org.apache.felix.gogo.runtime.Closure.execute(Closure.java:183)[17:org.apache.karaf.shell.console:2.4.2.SNAPSHOT]
        at org.apache.felix.gogo.runtime.Closure.execute(Closure.java:120)[17:org.apache.karaf.shell.console:2.4.2.SNAPSHOT]
        at org.apache.felix.gogo.runtime.CommandSessionImpl.execute(CommandSessionImpl.java:92)[17:org.apache.karaf.shell.console:2.4.2.SNAPSHOT]
        at org.apache.karaf.shell.console.jline.Console.run(Console.java:195)[17:org.apache.karaf.shell.console:2.4.2.SNAPSHOT]
        at java.lang.Thread.run(Thread.java:745)[:1.7.0_67]