[KARAF-3562] DefaultJDBCLock case sensitive issue

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.3.9
• Fix Version/s: 2.4.2, 3.0.4, 2.3.11, 4.0.0.M3
• Component/s: karaf
• Assignee: Jean-Baptiste Onofré
• Reporter: Paolo Antinori
• Created: 25/Feb/15 14:03
• Updated: 14/Sep/18 08:35
• Resolved: 01/Apr/15 09:16

Description

There's a possible issue with:

 rs = getConnection().getMetaData().getTables(null, null, tableName, new String[] {"TABLE"});
schemaExists = rs.next();

in

https://github.com/apache/karaf/blob/master/main/src/main/java/org/apache/karaf/main/lock/DefaultJDBCLock.java#L165-L167

I'm using Postgres9.3 without any specific configuration.
I have configured the locking mechanism to use the property karaf.lock.jdbc.table=KARAF_LOCK
but Postgres stores the table name in its catalog in lowercase, so the query always returns a 0 length ResultSet.

I couldn't find a short form in the JDBC api to ignore the case.

I think this might be the default on Postgres, to convert it's catalog to lowercase, but I learn that this depends on the db configuration usually.

So I suggest one of this possible options:

• try both upper and lower case
• improve logging to show which is table with the exact case that is checked
• specialize PostgresJDBCLock if we can make the assumption that's pg default.

And eventually improve Karaf docs to suggest trying to specify a lower case name in case of errors.