[KARAF-3377] Starting Karaf on Windows changes console title

• Type: Bug
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 2.4.0, 3.0.2
• Fix Version/s: 3.0.3, 2.4.1, 4.0.0.M2, 4.0.0.M3
• Component/s: karaf

Environment

Windows

• Assignee: Jean-Baptiste Onofré
• Reporter: Claus Ibsen
• Created: 25/Nov/14 19:14
• Updated: 15/Sep/18 16:35
• Resolved: 28/Dec/14 20:30

Description

If you want to start karaf on windows, you can use

bin\start

And it startup karaf, but the start.bat script has an issue.

a) it set the title of current command window to KARAF_TITLE
b) it sets the spawned command window to hardcoded Karaf

The problem is that it should not do (a) as the current command window is just a CLI to control karaf, not to run the karaf itself.

And for (b) it should actually use KARAF_TITLE as the title, so you can control this.

This code at should be removed
https://github.com/apache/karaf/blob/master/assemblies/features/framework/src/main/filtered-resources/resources/bin/start.bat#L33

And the KARAF_TITLE code from above should be used here instead, eg so the spawned window gets the title of choice
https://github.com/apache/karaf/blob/master/assemblies/features/framework/src/main/filtered-resources/resources/bin/start.bat#L90