[KARAF-2497] NPE in PropertiesLoginModule

• Type: Bug
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 2.3.3
• Fix Version/s: 2.4.0, 3.0.0, 2.3.4
• Assignee: Jean-Baptiste Onofré
• Reporter: Claus Ibsen
• Created: 03/Oct/13 11:33
• Updated: 08/Oct/13 14:27
• Resolved: 08/Oct/13 14:27

Description

Notice this stacktrace during an karaf itest in ActiveMQ

Caused by: javax.security.auth.login.LoginException: java.lang.NullPointerException
	at java.lang.String.<init>(String.java:168)
	at org.apache.karaf.jaas.modules.properties.PropertiesLoginModule.login(PropertiesLoginModule.java:85)
	at org.apache.karaf.jaas.boot.ProxyLoginModule.login(ProxyLoginModule.java:83)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.lang.reflect.Method.invoke(Method.java:606)
	at javax.security.auth.login.LoginContext.invoke(LoginContext.java:784)
	at javax.security.auth.login.LoginContext.access$000(LoginContext.java:203)
	at javax.security.auth.login.LoginContext$4.run(LoginContext.java:698)
	at javax.security.auth.login.LoginContext$4.run(LoginContext.java:696)
	at java.security.AccessController.doPrivileged(Native Method)
	at javax.security.auth.login.LoginContext.invokePriv(LoginContext.java:695)
	at javax.security.auth.login.LoginContext.login(LoginContext.java:594)
	at org.apache.activemq.security.JaasAuthenticationBroker.addConnection(JaasAuthenticationBroker.java:73)
	at org.apache.activemq.broker.MutableBrokerFilter.addConnection(MutableBrokerFilter.java:97)

I guess the PropertiesLoginModule could deal with this an possible throw a more meaningful exception instead of NPE if something is not correct.