[KARAF-2421] FeatureFinder should prevent ArrayIndexOutOfBoundException

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 2.3.3, 2.4.0, 3.0.0
• Assignee: Jean-Baptiste Onofré
• Reporter: Jean-Baptiste Onofré
• Created: 31/Jul/13 03:54
• Updated: 28/Aug/13 06:48
• Resolved: 28/Aug/13 06:48

Description

FeatureFinder is used in feature:repo-add command to register a feature URL.

If the feature URL is malformed, we have an ArrayIndexOutOfBoundException:

2013-07-31 05:51:25,310 | ERROR | Local user karaf | ShellUtil | 39 - org.apache.karaf.shell.console - 3.0.0.SNAPSHOT | Exception caught while executing command
java.lang.ArrayIndexOutOfBoundsException: 4
at org.apache.karaf.features.command.Artifact.<init>(Artifact.java:35)
at org.apache.karaf.features.command.FeatureFinder.getUriFor(FeatureFinder.java:41)
at org.apache.karaf.features.command.RepoAddCommand.doExecute(RepoAddCommand.java:52)
at org.apache.karaf.shell.console.AbstractAction.execute(AbstractAction.java:33)
at org.apache.karaf.shell.commands.basic.AbstractCommand.execute(AbstractCommand.java:33)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)[:1.7.0_21]
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)[:1.7.0_21]
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)[:1.7.0_21]
at java.lang.reflect.Method.invoke(Method.java:601)[:1.7.0_21]
at org.apache.aries.proxy.impl.ProxyHandler$1.invoke(ProxyHandler.java:54)
at org.apache.aries.proxy.impl.ProxyHandler.invoke(ProxyHandler.java:119)
at org.apache.karaf.shell.console.commands.$BlueprintCommand541769319.execute(Unknown Source)
at org.apache.felix.gogo.runtime.CommandProxy.execute(CommandProxy.java:78)
at org.apache.felix.gogo.runtime.Closure.executeCmd(Closure.java:477)
at org.apache.felix.gogo.runtime.Closure.executeStatement(Closure.java:403)
at org.apache.felix.gogo.runtime.Pipe.run(Pipe.java:108)
at org.apache.felix.gogo.runtime.Closure.execute(Closure.java:183)