Karaf
  1. Karaf
  2. KARAF-1752

hard coded features uri in features deployer feature discovery

    Details

    • Type: Improvement Improvement
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.3.0, 3.0.0.RC1
    • Component/s: None
    • Labels:
      None

      Issue Links

        Activity

        Hide
        Andrei Pozolotin added a comment -

        problem: current FeatureDeploymentListener will accept only v. 1.0.0 uri

        Show
        Andrei Pozolotin added a comment - problem: current FeatureDeploymentListener will accept only v. 1.0.0 uri
        Hide
        Andrei Pozolotin added a comment -

        probably should move isKnownFeaturesURI() into features.core static util class

        Show
        Andrei Pozolotin added a comment - probably should move isKnownFeaturesURI() into features.core static util class
        Hide
        Andrei Pozolotin added a comment -

        on the other hand, uri validation is overkill and does not really help;

        instead, just try to unmarshal xml into a bean,
        return true on success, false on parser exception

        Show
        Andrei Pozolotin added a comment - on the other hand, uri validation is overkill and does not really help; instead, just try to unmarshal xml into a bean, return true on success, false on parser exception
        Hide
        Andreas Pieber added a comment -

        I wouldn't call it a bug to have it hardcoded; rather an improvement to get rid of it

        Show
        Andreas Pieber added a comment - I wouldn't call it a bug to have it hardcoded; rather an improvement to get rid of it
        Hide
        Andreas Pieber added a comment -

        Committed r1376824
        M tooling/karaf-maven-plugin/src/test/java/org/apache/karaf/tooling/features/GenerateDescriptorMojoTest.java
        M deployer/features/src/main/java/org/apache/karaf/deployer/features/FeatureDeploymentListener.java
        D features/core/src/main/java/org/apache/karaf/features/internal/FeaturesNamespaces.java
        M features/core/src/main/java/org/apache/karaf/features/internal/model/JaxbUtil.java
        M features/core/src/main/java/org/apache/karaf/features/internal/model/package-info.java
        M features/core/src/main/java/org/apache/karaf/features/internal/FeatureValidationUtil.java
        A features/core/src/main/java/org/apache/karaf/features/FeaturesNamespaces.java
        W: -empty_dir: karaf/trunk/features/core/src/main/java/org/apache/karaf/features/internal/FeaturesNamespaces.java
        r1376824 = b78b666ca484aaf4ca997a3cd7a5f8b649943605 (refs/remotes/origin/trunk)

        Show
        Andreas Pieber added a comment - Committed r1376824 M tooling/karaf-maven-plugin/src/test/java/org/apache/karaf/tooling/features/GenerateDescriptorMojoTest.java M deployer/features/src/main/java/org/apache/karaf/deployer/features/FeatureDeploymentListener.java D features/core/src/main/java/org/apache/karaf/features/internal/FeaturesNamespaces.java M features/core/src/main/java/org/apache/karaf/features/internal/model/JaxbUtil.java M features/core/src/main/java/org/apache/karaf/features/internal/model/package-info.java M features/core/src/main/java/org/apache/karaf/features/internal/FeatureValidationUtil.java A features/core/src/main/java/org/apache/karaf/features/FeaturesNamespaces.java W: -empty_dir: karaf/trunk/features/core/src/main/java/org/apache/karaf/features/internal/FeaturesNamespaces.java r1376824 = b78b666ca484aaf4ca997a3cd7a5f8b649943605 (refs/remotes/origin/trunk)
        Hide
        Andreas Pieber added a comment -

        Hey Andrei,

        your patches KARAF-1738 and KARAF-1752 had been applied to the master. Would you mind to also give the backport to 2.3 a shot?

        Thx again and kind regards,
        Andreas

        Show
        Andreas Pieber added a comment - Hey Andrei, your patches KARAF-1738 and KARAF-1752 had been applied to the master. Would you mind to also give the backport to 2.3 a shot? Thx again and kind regards, Andreas
        Hide
        Andrei Pozolotin added a comment - - edited

        great! thank you; will take a look on "backport to 2.3" before Monday

        Show
        Andrei Pozolotin added a comment - - edited great! thank you; will take a look on "backport to 2.3" before Monday
        Hide
        Andreas Pieber added a comment -

        Great! Thank you very much Andrei! You effort is highly appreciated.

        Show
        Andreas Pieber added a comment - Great! Thank you very much Andrei! You effort is highly appreciated.
        Hide
        Andrei Pozolotin added a comment - - edited
        Show
        Andrei Pozolotin added a comment - - edited pull: https://github.com/apache/karaf/pull/7
        Hide
        Andrei Pozolotin added a comment -

        see: 0001-back-port-KARAF-1738-KARAF-1752.patch.txt

        Show
        Andrei Pozolotin added a comment - see: 0001-back-port- KARAF-1738 - KARAF-1752 .patch.txt
        Hide
        Andrei Pozolotin added a comment -

        please review/commit

        Show
        Andrei Pozolotin added a comment - please review/commit
        Hide
        Andreas Pieber added a comment -

        Also applied to 2.3.x

        Committed r1395904
        M deployer/features/src/main/java/org/apache/karaf/deployer/features/FeatureDeploymentListener.java
        M tooling/features-maven-plugin/src/test/java/org/apache/karaf/tooling/features/GenerateFeaturesXmlMojoTest.java
        A tooling/features-maven-plugin/src/test/resources/features-01.xml
        M tooling/features-maven-plugin/src/main/java/org/apache/karaf/tooling/features/GenerateFeaturesXmlMojo.java
        M features/core/src/main/java/org/apache/karaf/features/internal/FeatureValidationUtil.java
        A features/core/src/main/java/org/apache/karaf/features/FeaturesNamespaces.java
        A features/core/src/main/resources/org/apache/karaf/features/karaf-features-1.1.0.xsd
        r1395904 = 6330333882857f5ba3052cdf70dd0aebd5b3bcf8 (refs/remotes/origin/karaf-2.3.x)

        Show
        Andreas Pieber added a comment - Also applied to 2.3.x Committed r1395904 M deployer/features/src/main/java/org/apache/karaf/deployer/features/FeatureDeploymentListener.java M tooling/features-maven-plugin/src/test/java/org/apache/karaf/tooling/features/GenerateFeaturesXmlMojoTest.java A tooling/features-maven-plugin/src/test/resources/features-01.xml M tooling/features-maven-plugin/src/main/java/org/apache/karaf/tooling/features/GenerateFeaturesXmlMojo.java M features/core/src/main/java/org/apache/karaf/features/internal/FeatureValidationUtil.java A features/core/src/main/java/org/apache/karaf/features/FeaturesNamespaces.java A features/core/src/main/resources/org/apache/karaf/features/karaf-features-1.1.0.xsd r1395904 = 6330333882857f5ba3052cdf70dd0aebd5b3bcf8 (refs/remotes/origin/karaf-2.3.x)

          People

          • Assignee:
            Andreas Pieber
            Reporter:
            Andrei Pozolotin
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development