Details

      Activity

      Hide
      Andrei Pozolotin added a comment -

      actually, can we remove one-file-patch requirement?

      this is just another show stopper for a casual contributor.

      Show
      Andrei Pozolotin added a comment - actually, can we remove one-file-patch requirement? this is just another show stopper for a casual contributor.
      Hide
      Andreas Pieber added a comment -

      +1 from my point of view; feel free to go ahead and create the patch (thx for the contribution again)

      Show
      Andreas Pieber added a comment - +1 from my point of view; feel free to go ahead and create the patch (thx for the contribution again)
      Hide
      Andrei Pozolotin added a comment -

      please accept

      Show
      Andrei Pozolotin added a comment - please accept
      Show
      Andrei Pozolotin added a comment - update rules per JB comment; updated patch file https://issues.apache.org/jira/browse/KARAF-1048?focusedCommentId=13437949&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13437949
      Hide
      Jean-Baptiste Onofré added a comment -

      Thanks for the update Andrei. I complete another patch review and take a look on that.

      Show
      Jean-Baptiste Onofré added a comment - Thanks for the update Andrei. I complete another patch review and take a look on that.
      Hide
      Andreas Pieber added a comment -

      hey Andrei, a small comment for the future. If you upload a patch please attach .txt after the patch. That way we can directly give it a last review in the browser before applying and running the itests; I extend your guide for that bit of information

      Show
      Andreas Pieber added a comment - hey Andrei, a small comment for the future. If you upload a patch please attach .txt after the patch. That way we can directly give it a last review in the browser before applying and running the itests; I extend your guide for that bit of information
      Hide
      Andreas Pieber added a comment -

      Committed r1376609
      M manual/src/main/webapp/_navigation.conf
      M manual/src/main/webapp/developers-guide/index.conf
      A manual/src/main/webapp/developers-guide/github-contributions.conf
      r1376609 = b68094fce82ce4245bc5e84d4e72d65e25ee14b4 (refs/remotes/origin/trunk)

      Committed r1376652
      M manual/src/main/webapp/_navigation.conf
      M manual/src/main/webapp/developers-guide/index.conf
      A manual/src/main/webapp/developers-guide/github-contributions.conf
      r1376652 = 805b18574d9d4354123c29805a2d3e029106b1b9 (refs/remotes/origin/karaf-2.3.x)

      Show
      Andreas Pieber added a comment - Committed r1376609 M manual/src/main/webapp/_navigation.conf M manual/src/main/webapp/developers-guide/index.conf A manual/src/main/webapp/developers-guide/github-contributions.conf r1376609 = b68094fce82ce4245bc5e84d4e72d65e25ee14b4 (refs/remotes/origin/trunk) Committed r1376652 M manual/src/main/webapp/_navigation.conf M manual/src/main/webapp/developers-guide/index.conf A manual/src/main/webapp/developers-guide/github-contributions.conf r1376652 = 805b18574d9d4354123c29805a2d3e029106b1b9 (refs/remotes/origin/karaf-2.3.x)
      Hide
      Andrei Pozolotin added a comment -

      ok, got it re "txt"; thank you for the commit

      Show
      Andrei Pozolotin added a comment - ok, got it re "txt"; thank you for the commit

        People

        • Assignee:
          Andreas Pieber
          Reporter:
          Andrei Pozolotin
        • Votes:
          0 Vote for this issue
          Watchers:
          3 Start watching this issue

          Dates

          • Created:
            Updated:
            Resolved:

            Development