Uploaded image for project: 'Karaf'
  1. Karaf
  2. KARAF-1738

features-generate-descriptor should support "install" attribute

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 3.0.0
    • Component/s: karaf-tooling
    • Labels:
      None

      Description

      1. 0001-delivery.patch
        21 kB
        Andrei Pozolotin

        Issue Links

          Activity

          Hide
          jbonofre Jean-Baptiste Onofré added a comment -

          Merge in progress...

          Show
          jbonofre Jean-Baptiste Onofré added a comment - Merge in progress...
          Hide
          pieber Andreas Pieber added a comment - - edited

          applied on master by JB in https://svn.apache.org/viewvc?view=revision&revision=1375361

          Now needs to be back ported before it could be set to resolved

          Show
          pieber Andreas Pieber added a comment - - edited applied on master by JB in https://svn.apache.org/viewvc?view=revision&revision=1375361 Now needs to be back ported before it could be set to resolved
          Hide
          jbonofre Jean-Baptiste Onofré added a comment -

          lol, no problem. Just a bit of patience and all arrives

          Show
          jbonofre Jean-Baptiste Onofré added a comment - lol, no problem. Just a bit of patience and all arrives
          Hide
          andrei.pozolotin Andrei Pozolotin added a comment -

          wow! my prayers have been answered, thank you, God

          for the record, St. Andrew in now my favorite saint;
          but St. John the Baptist is also very cool - cheers!

          Show
          andrei.pozolotin Andrei Pozolotin added a comment - wow! my prayers have been answered, thank you, God for the record, St. Andrew in now my favorite saint; but St. John the Baptist is also very cool - cheers!
          Hide
          jbonofre Jean-Baptiste Onofré added a comment -

          Applied on trunk: http://svn.apache.org/viewvc?view=revision&revision=1375361

          For 2.3.0, I saw some incoherence (it still uses the 1.0.0 namespace whereas it contains 1.1.0 attributes, like install). I'm going to review the namespace and update karaf-2.3.x branch if applicable.

          Show
          jbonofre Jean-Baptiste Onofré added a comment - Applied on trunk: http://svn.apache.org/viewvc?view=revision&revision=1375361 For 2.3.0, I saw some incoherence (it still uses the 1.0.0 namespace whereas it contains 1.1.0 attributes, like install). I'm going to review the namespace and update karaf-2.3.x branch if applicable.
          Hide
          andrei.pozolotin Andrei Pozolotin added a comment -

          "applied tonight my time (PS time)" sounds great; thank you.

          Show
          andrei.pozolotin Andrei Pozolotin added a comment - "applied tonight my time (PS time)" sounds great; thank you.
          Hide
          jbonofre Jean-Baptiste Onofré added a comment -

          As you can see in the Jira status, it's "In Progress". So it means that I started to review the patch, test, change it (if required). I think it should be applied tonight my time (PS time).

          Show
          jbonofre Jean-Baptiste Onofré added a comment - As you can see in the Jira status, it's "In Progress". So it means that I started to review the patch, test, change it (if required). I think it should be applied tonight my time (PS time).
          Hide
          andrei.pozolotin Andrei Pozolotin added a comment -

          JB: can you please accept, reject or set a deadline for a decision? thanks, Andrei.

          Show
          andrei.pozolotin Andrei Pozolotin added a comment - JB: can you please accept, reject or set a deadline for a decision? thanks, Andrei.
          Hide
          pieber Andreas Pieber added a comment -

          Nothing to add from my point of view. Great work Andrei! ASAP as JB gives his +1 I can apply the patch. Thanks again and kind regards, Andreas

          Show
          pieber Andreas Pieber added a comment - Nothing to add from my point of view. Great work Andrei! ASAP as JB gives his +1 I can apply the patch. Thanks again and kind regards, Andreas
          Hide
          andrei.pozolotin Andrei Pozolotin added a comment -

          patch attached, please accept

          Show
          andrei.pozolotin Andrei Pozolotin added a comment - patch attached, please accept
          Hide
          pieber Andreas Pieber added a comment -

          My last review is attached to github. Once it reaches here an JB is happy we can apply I think

          Show
          pieber Andreas Pieber added a comment - My last review is attached to github. Once it reaches here an JB is happy we can apply I think
          Hide
          jbonofre Jean-Baptiste Onofré added a comment -

          Thanks for the patch, I gonna review it.

          Show
          jbonofre Jean-Baptiste Onofré added a comment - Thanks for the patch, I gonna review it.
          Hide
          andrei.pozolotin Andrei Pozolotin added a comment -

          please review #3

          Show
          andrei.pozolotin Andrei Pozolotin added a comment - please review #3
          Hide
          pieber Andreas Pieber added a comment -

          done

          Show
          pieber Andreas Pieber added a comment - done
          Hide
          andrei.pozolotin Andrei Pozolotin added a comment -

          Andreas:

          thanks for the ideas; implemented; please review again

          Andrei.

          Show
          andrei.pozolotin Andrei Pozolotin added a comment - Andreas: thanks for the ideas; implemented; please review again Andrei.
          Hide
          pieber Andreas Pieber added a comment -

          added my ideas to the pull request

          Show
          pieber Andreas Pieber added a comment - added my ideas to the pull request

            People

            • Assignee:
              jbonofre Jean-Baptiste Onofré
              Reporter:
              andrei.pozolotin Andrei Pozolotin
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development