Karaf
  1. Karaf
  2. KARAF-1657

org.ops4j.pax.url.mvn.proxySupport=false

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.2.9, 2.3.0, 3.0.0
    • Component/s: None
    • Labels:
      None

      Description

      #
      # Uncomment if you are behind a web proxy. PAX URL will use the proxy settings
      # from the Maven conf/settings.xml file
      #
      # org.ops4j.pax.url.mvn.proxySupport=true
      

      http://team.ops4j.org/wiki/display/paxurl/Mvn+Protocol

      The configuration of pax url is per default true. If you read this comment inside org.ops4j.pax.url.mvn.cfg you expect that the default configuration must be false.

      I prefer to set the configuration per default to false.

        Activity

        Hide
        Andreas Pieber added a comment -

        I'm also +1 for changing this to false; nevertheless, last time I chatted with JB about this the state was: we'll change this ASAP all side conditions are clear. Is there any update on this before we finally change this property?

        Show
        Andreas Pieber added a comment - I'm also +1 for changing this to false; nevertheless, last time I chatted with JB about this the state was: we'll change this ASAP all side conditions are clear. Is there any update on this before we finally change this property?
        Hide
        Freeman Fang added a comment - - edited

        Hi Andreas,

        We currently comment out org.ops4j.pax.url.mvn.proxySupport configuration by default, which means in Karaf we use default value of org.ops4j.pax.url.mvn.proxySupport from PAX-URL out-of-box so far, which is "true"(according to PAX-URL docs). By my test, the default org.ops4j.pax.url.mvn.proxySupport=true in PAX-URL means, it will just try to use(but not only use proxy) maven proxy support if the proxy configuration is in maven settings.xml and the proxy is available. That said, PAX-URL can still use normal maven way even the proxy isn't available or there's no proxy configuration in maven settings.xml with default org.ops4j.pax.url.mvn.proxySupport=true.

        So the current configuration (including the comments)

        #
        # Uncomment if you are behind a web proxy. PAX URL will use the proxy settings
        # from the Maven conf/settings.xml file
        #
        # org.ops4j.pax.url.mvn.proxySupport=true
        

        isn't correct, as it's actually same behavior with or without
        org.ops4j.pax.url.mvn.proxySupport=true

        So I think we need change it to

        #
        # Uncomment if you don't wanna use the proxy settings
        # from the Maven conf/settings.xml file
        #
        # org.ops4j.pax.url.mvn.proxySupport=false
        

        And I don't see the side effect of this change, as all what we change is still in the comment.

        I might miss something, so if other guys have different input, please let me know.

        Regards
        Freeman

        Show
        Freeman Fang added a comment - - edited Hi Andreas, We currently comment out org.ops4j.pax.url.mvn.proxySupport configuration by default, which means in Karaf we use default value of org.ops4j.pax.url.mvn.proxySupport from PAX-URL out-of-box so far, which is "true"(according to PAX-URL docs). By my test, the default org.ops4j.pax.url.mvn.proxySupport=true in PAX-URL means, it will just try to use(but not only use proxy) maven proxy support if the proxy configuration is in maven settings.xml and the proxy is available. That said, PAX-URL can still use normal maven way even the proxy isn't available or there's no proxy configuration in maven settings.xml with default org.ops4j.pax.url.mvn.proxySupport=true. So the current configuration (including the comments) # # Uncomment if you are behind a web proxy. PAX URL will use the proxy settings # from the Maven conf/settings.xml file # # org.ops4j.pax.url.mvn.proxySupport= true isn't correct, as it's actually same behavior with or without org.ops4j.pax.url.mvn.proxySupport=true So I think we need change it to # # Uncomment if you don't wanna use the proxy settings # from the Maven conf/settings.xml file # # org.ops4j.pax.url.mvn.proxySupport= false And I don't see the side effect of this change, as all what we change is still in the comment. I might miss something, so if other guys have different input, please let me know. Regards Freeman
        Show
        Freeman Fang added a comment - commit fix http://svn.apache.org/viewvc?rev=1364858&view=rev for trunk http://svn.apache.org/viewvc?rev=1364857&view=rev for 2.3.x branch http://svn.apache.org/viewvc?rev=1364856&view=rev for 2.2.x branch
        Hide
        Andreas Pieber added a comment -

        oh... dargl... this was the wrong org.ops4j.pax.url.mvn property I thought about. This happens if you read a post with only half your mind on ..

        Terrible sorry for the confusion and thanks for commiting/fixing this.

        Kind regards,
        Andreas

        Show
        Andreas Pieber added a comment - oh... dargl... this was the wrong org.ops4j.pax.url.mvn property I thought about. This happens if you read a post with only half your mind on . . Terrible sorry for the confusion and thanks for commiting/fixing this. Kind regards, Andreas

          People

          • Assignee:
            Freeman Fang
            Reporter:
            Michael Prieß
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development