Details
-
Type:
Improvement
-
Status: Resolved
-
Priority:
Major
-
Resolution: Fixed
-
Affects Version/s: None
-
Fix Version/s: 3.0.0
-
Component/s: None
-
Labels:None
Description
The client module currently depends on the console module but only uses the TerminalFactory from it and the karaf.key.
So I would like to change the client to only depend on jansi, jline, sshd and mina. The only question is where to get the karaf.key from.
There are three possible solutions:
1. Create a module for the key. This module could also contain the code to load the key and setup the agent. Client and console could then depend on this module
2. Put the key in etc e.g. in the file karaf.key. So client and console could simply read from that location
3. Let e.g. client push the key into a separate file in maven (attach-artifact). So we can then easily depend on it from client and console.
I prefer solution 1 as it can be extended to completely remove the agent code from console using org.apache.felix.gogo.api.CommandSessionListener. So the new module could add the agent to the session easily.