Karaf
  1. Karaf
  2. KARAF-1617

Blueprint deployer in combination with maven URL deployer creates wrong OSGi/blueprint/ file

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 2.2.8
    • Fix Version/s: 2.2.9, 2.3.0, 3.0.0
    • Component/s: karaf-core
    • Labels:
    • Environment:

      Karaf 2.2.8

      • org/apache/karaf/deployer/org.apache.karaf.deployer.blueprint/2.2.8
      • org/apache/aries/blueprint/org.apache.aries.blueprint/0.3.2

      Description

      We are using the Aries JNDI service for providing database-datasources via JNDI.

      The datasource definition is a blueprint-XML file like this one and is located in our Maven repository.

      I try to install the datasource definition like:

      bundle:install -s blueprint:mvn:my.product.database/my.product.database.layer//xml/datasource-hsqldb

      or via Kara feature:

      feature:install datasource-hsqldb

      features.xml
      [...]
      
        <feature name="datasource-hsqldb" version="${project.version}" resolver="(obr)">
          <feature>hsqldb</feature>
          <bundle >blueprint:mvn:my.product.database/my.product.database.layer/${project.version}/xml/datasource-hsqldb</bundle>
        </feature>
      
      [...]
      

      The bundle will be installed but the blueprint service was not created.

      The blueprint deployer creates a bundle-JAR file and including a new ZipEntry as blueprint service descriptor into OSGi/blueprint/.

      org.apache.karaf.deployer.blueprint.BlueprintTransformer.transform(URL, OutputStream)
      [...]
      
              String name = url.getPath();
              int idx = name.lastIndexOf('/');
              if (idx >= 0) {
                  name = name.substring(idx + 1);
              }
      
      [...]
      
              e = new ZipEntry("OSGI-INF/blueprint/" + name);
              out.putNextEntry(e);
              // Copy the new DOM
              if (tf == null) {
                  tf = TransformerFactory.newInstance();
              }
              tf.newTransformer().transform(new DOMSource(doc), new StreamResult(out));
              out.closeEntry();
      
      [...]
      

      Based on the mvn: URL the name of the blueprint descriptor file is datasource-hsqldb (w/o the .xml extension).

      The blueprint service needs the .xml file extension.

      org.apache.aries.blueprint.container.BlueprintExtender.checkBundle(Bundle)
      [...]
                 addEntries(bundle, name, "*.xml", pathList);
      [...]
      

        Activity

        Hide
        Uwe Barthel added a comment -

        Patch of src/main/java/org/apache/karaf/deployer/blueprint/BlueprintTransformer.java and JUnit tests included

        Show
        Uwe Barthel added a comment - Patch of src/main/java/org/apache/karaf/deployer/blueprint/BlueprintTransformer.java and JUnit tests included
        Hide
        Jamie goodyear added a comment -

        Thank you Uwe Barthel for the patch!

        Show
        Jamie goodyear added a comment - Thank you Uwe Barthel for the patch!
        Hide
        Freeman Fang added a comment -

        HI Uwe,

        Your patch miss a test file test-fileextension, not a big deal though. I added it.
        Thanks for the patch

        Freeman

        Show
        Freeman Fang added a comment - HI Uwe, Your patch miss a test file test-fileextension, not a big deal though. I added it. Thanks for the patch Freeman
        Hide
        Freeman Fang added a comment -
        Show
        Freeman Fang added a comment - apply patch on behalf of Uwe Barthel with thanks http://svn.apache.org/viewvc?rev=1358899&view=rev for trunk http://svn.apache.org/viewvc?rev=1358900&view=rev for 2.3.x branch http://svn.apache.org/viewvc?rev=1358898&view=rev for 2.2.x branch
        Hide
        Uwe Barthel added a comment -

        Tested with 2.2.9-SNAPSHOT. Works fine. Thx.

        Show
        Uwe Barthel added a comment - Tested with 2.2.9-SNAPSHOT. Works fine. Thx.

          People

          • Assignee:
            Freeman Fang
            Reporter:
            Uwe Barthel
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development