Karaf
  1. Karaf
  2. KARAF-1367

Remove line number logging from default logging config

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 2.2.6
    • Fix Version/s: 2.2.7, 2.4.0, 3.0.0
    • Component/s: karaf-core
    • Labels:
      None

      Description

      This was fixed in ServiceMix a while ago in https://issues.apache.org/jira/browse/SMX4-748 and would be nice to get fixed in Karaf as well. Essentially, outputting the line number ("L" option) is super slow according to the log4j docs: http://logging.apache.org/log4j/1.2/apidocs/org/apache/log4j/PatternLayout.html

      Attaching patches shortly.

      1. KARAF-1367-trunk.patch
        3 kB
        Jonathan Anstey
      2. KARAF-1367-2.2.x.patch
        3 kB
        Jonathan Anstey

        Activity

        Jonathan Anstey created issue -
        Hide
        Jonathan Anstey added a comment -

        Patch for 2.2.x branch.

        Show
        Jonathan Anstey added a comment - Patch for 2.2.x branch.
        Jonathan Anstey made changes -
        Field Original Value New Value
        Attachment KARAF-1367-2.2.x.patch [ 12522564 ]
        Hide
        Jonathan Anstey added a comment -

        Patch for trunk.

        Show
        Jonathan Anstey added a comment - Patch for trunk.
        Jonathan Anstey made changes -
        Attachment KARAF-1367-trunk.patch [ 12522565 ]
        Jean-Baptiste Onofré made changes -
        Assignee Jean-Baptiste Onofré [ jbonofre ]
        Jean-Baptiste Onofré made changes -
        Fix Version/s 2.2.7 [ 12320174 ]
        Fix Version/s 3.0.0 [ 12316040 ]
        Component/s karaf-core [ 12313724 ]
        Jean-Baptiste Onofré made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Hide
        Jonathan Anstey added a comment -

        Cool, just saw that you committed this. Thanks JB

        Show
        Jonathan Anstey added a comment - Cool, just saw that you committed this. Thanks JB
        Jamie goodyear made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Jonathan Anstey made changes -
        Resolution Fixed [ 1 ]
        Status Closed [ 6 ] Reopened [ 4 ]
        Assignee Jean-Baptiste Onofré [ jbonofre ] Jonathan Anstey [ janstey ]
        Jonathan Anstey made changes -
        Fix Version/s 2.4.0 [ 12323352 ]
        Hide
        Jonathan Anstey added a comment -
        Show
        Jonathan Anstey added a comment - Fixed for 2.4 as well http://git-wip-us.apache.org/repos/asf/karaf/commit/93f6515c
        Jonathan Anstey made changes -
        Status Reopened [ 4 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Hide
        Jonathan Anstey added a comment -

        Fixed a cosmetic issue with this in https://github.com/apache/karaf/commit/e95d0dea50bea4f67b7a88d8cdbfb344c26f3285. log:display was outputting ? for the log field we were not recording anymore.

        Show
        Jonathan Anstey added a comment - Fixed a cosmetic issue with this in https://github.com/apache/karaf/commit/e95d0dea50bea4f67b7a88d8cdbfb344c26f3285 . log:display was outputting ? for the log field we were not recording anymore.
        Transition Time In Source Status Execution Times Last Executer Last Execution Date
        Open Open Resolved Resolved
        2d 6h 36m 1 Jean-Baptiste Onofré 15/Apr/12 20:17
        Resolved Resolved Closed Closed
        17d 17h 17m 1 Jamie goodyear 03/May/12 13:34
        Closed Closed Reopened Reopened
        719d 1h 9m 1 Jonathan Anstey 22/Apr/14 14:44
        Reopened Reopened Resolved Resolved
        24s 1 Jonathan Anstey 22/Apr/14 14:44

          People

          • Assignee:
            Jonathan Anstey
            Reporter:
            Jonathan Anstey
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development