Karaf
  1. Karaf
  2. KARAF-1293

feature level start-level not completely finished....

    Details

      Description

      The start-level attribute at the feature level that was introduced in KARAF-576 isn't completely working. First, the schema on the web site at:

      http://karaf.apache.org/xmlns/features/v1.0.0

      doesn't have it. Thus, some xml validation fails.

      Second, the schema in the tools:

      ./tooling/features-maven-plugin/src/main/resources/org/apache/karaf/features/karaf-features-1.0.0-ordered.xsd

      also doesn't have it. (I'm not sure why that second schema even exists)

        Activity

        Hide
        Freeman Fang added a comment -

        Hi Dan,

        I changed the xsd files in source but seems we didn't update the online schema file after each Karaf release, so the online schema is out-of-data.

        @JB and @Jamie,
        Could you please help to update the online schema, should we do it automatically?

        Btw, I'm not sure why we need tooling/features-maven-plugin/src/main/resources/org/apache/karaf/features/karaf-features-1.0.0-ordered.xsd here as well, could any guys comment/clarify?

        Regards
        Freeman

        Show
        Freeman Fang added a comment - Hi Dan, I changed the xsd files in source but seems we didn't update the online schema file after each Karaf release, so the online schema is out-of-data. @JB and @Jamie, Could you please help to update the online schema, should we do it automatically? Btw, I'm not sure why we need tooling/features-maven-plugin/src/main/resources/org/apache/karaf/features/karaf-features-1.0.0-ordered.xsd here as well, could any guys comment/clarify? Regards Freeman
        Hide
        Daniel Kulp added a comment -

        Freeman,

        I THINK the second xsd is used in the way Camel sets up it's itest-osgi test suite. If you have a start-level on a feature element, it complains that it cannot validate the feature.xml. I did a wireshark on it and didn't see it trying to hit the web site for the schema, so it looks like it's getting the schema internally. I haven't dug in completely yet, but if the main schema is updated to have the proper attribute, it looks likt he one in the maven-plugin is used in this case somehow. Really not sure though.

        Dan

        Show
        Daniel Kulp added a comment - Freeman, I THINK the second xsd is used in the way Camel sets up it's itest-osgi test suite. If you have a start-level on a feature element, it complains that it cannot validate the feature.xml. I did a wireshark on it and didn't see it trying to hit the web site for the schema, so it looks like it's getting the schema internally. I haven't dug in completely yet, but if the main schema is updated to have the proper attribute, it looks likt he one in the maven-plugin is used in this case somehow. Really not sure though. Dan
        Hide
        Jean-Baptiste Onofré added a comment -

        I will handle the xsd update and check all.

        Show
        Jean-Baptiste Onofré added a comment - I will handle the xsd update and check all.
        Hide
        Claus Ibsen added a comment -

        Has the online XSD been updated?

        I can see a start-level attribute but thats only for <bundle>

        Show
        Claus Ibsen added a comment - Has the online XSD been updated? I can see a start-level attribute but thats only for <bundle>
        Hide
        Claus Ibsen added a comment -

        Also why is a v1.0.0 XSD schema being changed? When it has been published, then IMHO it should never change!

        Show
        Claus Ibsen added a comment - Also why is a v1.0.0 XSD schema being changed ? When it has been published, then IMHO it should never change!
        Hide
        Jean-Baptiste Onofré added a comment -

        I've updated v1.0.0 on the website and deployed v1.1.0 as well.

        I'm upgrading in the svn structure.

        Show
        Jean-Baptiste Onofré added a comment - I've updated v1.0.0 on the website and deployed v1.1.0 as well. I'm upgrading in the svn structure.
        Hide
        Claus Ibsen added a comment -

        Okay so the v1.1.0 has the start-level on the features xml element
        http://karaf.apache.org/xmlns/features/v1.1.0

        And I assume the old 1.0.0 is kept without that option, as this was the 1st release?

        Show
        Claus Ibsen added a comment - Okay so the v1.1.0 has the start-level on the features xml element http://karaf.apache.org/xmlns/features/v1.1.0 And I assume the old 1.0.0 is kept without that option, as this was the 1st release?
        Hide
        Jean-Baptiste Onofré added a comment -

        No, Freeman added the start-level attribute before the creation of 1.1.0. So 1.0.0 contains the start-level attribute. It's not very elegant and we should have created the 1.1.0 at that time, but it wasn't the case. So both 1.0.0 and 1.1.0 contain the feature start-level attribute.

        Show
        Jean-Baptiste Onofré added a comment - No, Freeman added the start-level attribute before the creation of 1.1.0. So 1.0.0 contains the start-level attribute. It's not very elegant and we should have created the 1.1.0 at that time, but it wasn't the case. So both 1.0.0 and 1.1.0 contain the feature start-level attribute.
        Hide
        Claus Ibsen added a comment -

        Ah thanks the online schema for 1.0.0 has been re-published and have the start-level attribute for features now as well.

        Thanks.

        Show
        Claus Ibsen added a comment - Ah thanks the online schema for 1.0.0 has been re-published and have the start-level attribute for features now as well. Thanks.

          People

          • Assignee:
            Jean-Baptiste Onofré
            Reporter:
            Daniel Kulp
          • Votes:
            1 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development