Karaf
  1. Karaf
  2. KARAF-1268

Allow multiple commands in karaf script

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 2.2.5
    • Fix Version/s: 2.2.6
    • Component/s: None
    • Labels:
      None

      Description

      If you follow the steps at http://karaf.apache.org/manual/latest-2.2.x/users-guide/start-stop.html under "Starting Karaf from clean" it tells you to run:

      bin/start clean

      which won't actually work. It runs "bin/karaf server clean" under the hood and the karaf script only looks at the first command passed in, so clean is ignored.

      Attaching a patch shortly to fix this.

      1. KARAF-1268.patch
        3 kB
        Jonathan Anstey

        Issue Links

          Activity

          Jamie goodyear made changes -
          Status Resolved [ 5 ] Closed [ 6 ]
          Jamie goodyear made changes -
          Link This issue is cloned as KARAF-1270 [ KARAF-1270 ]
          Hide
          Jonathan Anstey added a comment -

          Thanks dude.

          Show
          Jonathan Anstey added a comment - Thanks dude.
          Jamie goodyear made changes -
          Resolution Fixed [ 1 ]
          Status In Progress [ 3 ] Resolved [ 5 ]
          Hide
          Jamie goodyear added a comment -

          Patch applied with thanks to Jon Anstey.

          $ svn ci
          Sending assemblies/apache-karaf/src/main/distribution/unix-shell/bin/karaf
          Sending assemblies/apache-karaf/src/main/distribution/windows-text/bin/start.bat
          Transmitting file data ..
          Committed revision 1301215.

          Show
          Jamie goodyear added a comment - Patch applied with thanks to Jon Anstey. $ svn ci Sending assemblies/apache-karaf/src/main/distribution/unix-shell/bin/karaf Sending assemblies/apache-karaf/src/main/distribution/windows-text/bin/start.bat Transmitting file data .. Committed revision 1301215.
          Jamie goodyear made changes -
          Issue Type Improvement [ 4 ] Bug [ 1 ]
          Jamie goodyear made changes -
          Fix Version/s 2.2.6 [ 12319142 ]
          Jamie goodyear made changes -
          Status Open [ 1 ] In Progress [ 3 ]
          Hide
          Jamie goodyear added a comment - - edited

          I'll review and apply the patch - I'd rather see unix & windows scripts support equivalent features.

          Considering we document this as working with start clean command, I'd consider this a bug to not work as described.

          Show
          Jamie goodyear added a comment - - edited I'll review and apply the patch - I'd rather see unix & windows scripts support equivalent features. Considering we document this as working with start clean command, I'd consider this a bug to not work as described.
          Jamie goodyear made changes -
          Assignee Jamie goodyear [ jgoodyear ]
          Jonathan Anstey made changes -
          Field Original Value New Value
          Attachment KARAF-1268.patch [ 12518512 ]
          Hide
          Jonathan Anstey added a comment -

          Patch that fixes the issue on 2.2.x branch.

          It loops through all arguments now so you can even do something like:

          ./bin/karaf clean debug server

          Funny thing is that this is now the same behaviour as the karaf.bat script has always had

          Show
          Jonathan Anstey added a comment - Patch that fixes the issue on 2.2.x branch. It loops through all arguments now so you can even do something like: ./bin/karaf clean debug server Funny thing is that this is now the same behaviour as the karaf.bat script has always had
          Jonathan Anstey created issue -

            People

            • Assignee:
              Jamie goodyear
              Reporter:
              Jonathan Anstey
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development