Uploaded image for project: 'Kafka'
  1. Kafka
  2. KAFKA-943

Move all configuration key string to constants

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Major
    • Resolution: Won't Fix
    • Affects Version/s: 0.8.0
    • Fix Version/s: None
    • Component/s: config
    • Labels:
      None

      Description

      The current code base has configuration key strings duplicated all over the place. They show up in the actual *Config classes, a lot of tests, command line utilities and other examples. This makes changes hard and error prone. DRY...

      The attached patch moves these configuration keys to constants and replaces their usage with a reference to the constant. It also cleans up a few old properties and a few misconfigured tests. I've admittedly not written a whole lot of Scala, so there may be some improvements that can be made, in particular I am not sure I chose the best strategy for keys needed by the SyncProducerConfigShared trait (or traits in general).

        Attachments

          Activity

            People

            • Assignee:
              Unassigned
              Reporter:
              smeder Sam Meder
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: