Kafka
  1. Kafka
  2. KAFKA-93

Change code header to follow standard ASF source header

    Details

    • Type: Task Task
    • Status: Resolved
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.8.0
    • Component/s: None
    • Labels:
      None

      Description

      Need to update Kafka code to include ASF standard source header: http://www.apache.org/legal/src-headers.html

      I think most Kafka code already have the ASF header. Just need to remove the copyrights section of the comment per guideline.

        Activity

        Hide
        Henry Saputra added a comment -

        Committed as revision 1156232.

        Show
        Henry Saputra added a comment - Committed as revision 1156232.
        Hide
        Joel Koshy added a comment -

        Hi Henry, there are a few more files:

        grep -irH linkedin * | grep -v \.svn
        LICENSE: Copyright 2010 LinkedIn
        clients/clojure/LICENSE:Copyright 2011 LinkedIn
        clients/cpp/LICENSE:Copyright 2011 LinkedIn
        clients/csharp/LICENSE:Copyright 2011 LinkedIn
        clients/php/LICENSE:Copyright 2011 LinkedIn
        clients/python/kafka.py:# Copyright 2010 LinkedIn
        clients/python/setup.py: author='LinkedIn.com',
        clients/ruby/LICENSE:Copyright 2011 LinkedIn
        core/src/main/scala/kafka/tools/GetOffsetShell.scala:* Copyright 2010 LinkedIn
        core/src/test/scala/unit/kafka/producer/ProducerMethodsTest.scala: * Copyright 2011 LinkedIn
        perf/.classpath: <classpathentry kind="lib" path="/Users/femekci/linkedInSrc/kafka-multifetch/lib/scala-library-2.8.0.jar"/>
        perf/.classpath: <classpathentry kind="lib" path="/Users/femekci/linkedInSrc/kafka-multifetch/dist/kafka-0.04.6.0.jar"/>

        Show
        Joel Koshy added a comment - Hi Henry, there are a few more files: grep -irH linkedin * | grep -v \.svn LICENSE: Copyright 2010 LinkedIn clients/clojure/LICENSE:Copyright 2011 LinkedIn clients/cpp/LICENSE:Copyright 2011 LinkedIn clients/csharp/LICENSE:Copyright 2011 LinkedIn clients/php/LICENSE:Copyright 2011 LinkedIn clients/python/kafka.py:# Copyright 2010 LinkedIn clients/python/setup.py: author='LinkedIn.com', clients/ruby/LICENSE:Copyright 2011 LinkedIn core/src/main/scala/kafka/tools/GetOffsetShell.scala:* Copyright 2010 LinkedIn core/src/test/scala/unit/kafka/producer/ProducerMethodsTest.scala: * Copyright 2011 LinkedIn perf/.classpath: <classpathentry kind="lib" path="/Users/femekci/linkedInSrc/kafka-multifetch/lib/scala-library-2.8.0.jar"/> perf/.classpath: <classpathentry kind="lib" path="/Users/femekci/linkedInSrc/kafka-multifetch/dist/kafka-0.04.6.0.jar"/>
        Hide
        Joel Koshy added a comment -

        Also, do test bash scripts (e.g., the system tests) need the license. How about config files? Do these fall under "source"? I don't see any comment on this in http://www.apache.org/legal/src-headers.html

        Show
        Joel Koshy added a comment - Also, do test bash scripts (e.g., the system tests) need the license. How about config files? Do these fall under "source"? I don't see any comment on this in http://www.apache.org/legal/src-headers.html
        Hide
        Henry Saputra added a comment -

        Re-open for missing source and script files.

        Show
        Henry Saputra added a comment - Re-open for missing source and script files.
        Hide
        Henry Saputra added a comment -

        Thanks Joel, apparently my update script somehow miss some scala files. I need to make sure it covers clients file too.

        Show
        Henry Saputra added a comment - Thanks Joel, apparently my update script somehow miss some scala files. I need to make sure it covers clients file too.
        Hide
        Henry Saputra added a comment -

        Remove LinkedIn copyrights line and add ASF to some files.

        We will just add changes directly for missing ASF license header. Closing this as resolved.

        Show
        Henry Saputra added a comment - Remove LinkedIn copyrights line and add ASF to some files. We will just add changes directly for missing ASF license header. Closing this as resolved.
        Hide
        Jakob Homan added a comment -

        @Henry - I believe, per the user mailing list, we're using RTC for patches in Kafka, so you need to upload the patch you'd like to commit and get a +1 before actually applying it. Can you upload the patch you've committed?

        Show
        Jakob Homan added a comment - @Henry - I believe, per the user mailing list, we're using RTC for patches in Kafka, so you need to upload the patch you'd like to commit and get a +1 before actually applying it. Can you upload the patch you've committed?
        Hide
        Henry Saputra added a comment -

        Hi Jakob, I think for this case not much review needed. I just change the header comment.

        You can take a look at list of file changed in the Subversion Commits tab for this Jira.

        Show
        Henry Saputra added a comment - Hi Jakob, I think for this case not much review needed. I just change the header comment. You can take a look at list of file changed in the Subversion Commits tab for this Jira.
        Hide
        Jakob Homan added a comment -

        @Henry - the LICENSE files you've committed are incorrect in that you didn't replace the copyright year or name of copyright holder from the boiler text. Perhaps, had the patch been uploaded for review as part of the RTC process that's been agreed upon, this would have been caught before the commit.

        Show
        Jakob Homan added a comment - @Henry - the LICENSE files you've committed are incorrect in that you didn't replace the copyright year or name of copyright holder from the boiler text. Perhaps, had the patch been uploaded for review as part of the RTC process that's been agreed upon, this would have been caught before the commit.
        Hide
        Henry Saputra added a comment -

        You are talking about Copyright [yyyy] [name of copyright owner]?

        I thought this is just template that need to fill in by someone including Kafka in their project?

        I will follow RTC process next time.

        Show
        Henry Saputra added a comment - You are talking about Copyright [yyyy] [name of copyright owner] ? I thought this is just template that need to fill in by someone including Kafka in their project? I will follow RTC process next time.
        Hide
        Henry Saputra added a comment -

        @Jakob From the ASF license file itself:

        APPENDIX: How to apply the Apache License to your work.

        To apply the Apache License to your work, attach the following
        boilerplate notice, with the fields enclosed by brackets "[]"
        replaced with your own identifying information. (Don't include
        the brackets!) The text should be enclosed in the appropriate
        comment syntax for the file format. We also recommend that a
        file or class name and description of purpose be included on the
        same "printed page" as the copyright notice for easier
        identification within third-party archives.

        Copyright [yyyy] [name of copyright owner]

        ....

        The boiler plate is used to add Apache license to you own source which LinkedIn has done before moving Kafka to ASF incubator. Since Kafka is moving under ASF umbrella I modified the header comment to follow ASF guideline.

        Please let me know if I have interpreted this incorrectly.

        Show
        Henry Saputra added a comment - @Jakob From the ASF license file itself: APPENDIX: How to apply the Apache License to your work. To apply the Apache License to your work, attach the following boilerplate notice, with the fields enclosed by brackets "[]" replaced with your own identifying information. (Don't include the brackets!) The text should be enclosed in the appropriate comment syntax for the file format. We also recommend that a file or class name and description of purpose be included on the same "printed page" as the copyright notice for easier identification within third-party archives. Copyright [yyyy] [name of copyright owner] .... The boiler plate is used to add Apache license to you own source which LinkedIn has done before moving Kafka to ASF incubator. Since Kafka is moving under ASF umbrella I modified the header comment to follow ASF guideline. Please let me know if I have interpreted this incorrectly.
        Hide
        Chris Burroughs added a comment -

        Are all of the clients from LinkedIn? I thought some were from external pull requests.

        Show
        Chris Burroughs added a comment - Are all of the clients from LinkedIn? I thought some were from external pull requests.
        Hide
        Henry Saputra added a comment -

        Looks like all of them has LinkedIn as Copyright holder in the LICENSE.

        Show
        Henry Saputra added a comment - Looks like all of them has LinkedIn as Copyright holder in the LICENSE.
        Hide
        Henry Saputra added a comment -

        But previously LinkedIn has applied LICENSE file incorrectly in Kafka source tree. AFAIK, the Copyright [yyyy] [name of copyright owner] template is only replaced if you want to add ASF 2.0 license to your source code.

        You dont actually change the LICENSE file. Again please correct me if I am wrong.

        Show
        Henry Saputra added a comment - But previously LinkedIn has applied LICENSE file incorrectly in Kafka source tree. AFAIK, the Copyright [yyyy] [name of copyright owner] template is only replaced if you want to add ASF 2.0 license to your source code. You dont actually change the LICENSE file. Again please correct me if I am wrong.
        Hide
        Henry Saputra added a comment -

        Hi @Jakob, so are you ok with the checkins, especially the copyright issue you brought up before?

        Show
        Henry Saputra added a comment - Hi @Jakob, so are you ok with the checkins, especially the copyright issue you brought up before?
        Hide
        Jakob Homan added a comment -

        It's done now and we've clarified the correct procedure going forward, so it's fine.

        Show
        Jakob Homan added a comment - It's done now and we've clarified the correct procedure going forward, so it's fine.

          People

          • Assignee:
            Henry Saputra
            Reporter:
            Henry Saputra
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development