[KAFKA-9149] Avoid temp byte array creation when use ByteBufferSerializer

• Type: Improvement
• Status: Patch Available
• Priority: Major
• Resolution: Unresolved
• Affects Version/s: 2.3.0
• Component/s: clients
• Labels: Serializer
• Assignee: Unassigned
• Reporter: chenxu
• Created: 06/Nov/19 07:00
• Updated: 22/Nov/19 15:05

Description

Code in ByteBufferSerializer#serialize like this

public byte[] serialize(String topic, ByteBuffer data) {
  if (data == null)
    return null;
  data.rewind();
  if (data.hasArray()) {
    byte[] arr = data.array();
    if (data.arrayOffset() == 0 && arr.length == data.remaining()) {
      return arr;
    }
  }
  byte[] ret = new byte[data.remaining()];
  data.get(ret, 0, ret.length);
  data.rewind();
  return ret;
}

Temp byte array will be created when use with DirectByteBuffer, how about declare a method such as serialize2Buffer and return the ByteBuffer directly ? This can improve GC a lot in KafkaProducer.

Issue Links

• links to: GitHub Pull Request #7656