[KAFKA-9143] DistributedHerder misleadingly log error on connector task reconfiguration

• Type: Bug
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 2.2.3, 2.5.0, 2.3.2, 2.4.1
• Component/s: KafkaConnect
• Assignee: Ivan Yurchenko
• Reporter: Ivan Yurchenko
• Reviewer: Randall Hauch
• Created: 05/Nov/19 16:14
• Updated: 21/Jan/20 23:38
• Resolved: 21/Jan/20 23:38

Description

In DistributedHerder in reconfigureConnectorTasksWithRetry method there's a callback:

@Override
public void onCompletion(Throwable error, Void result) {
    log.error("Unexpected error during connector task reconfiguration: ", error);
    log.error("Task reconfiguration for {} failed unexpectedly, this connector will not be properly reconfigured unless manually triggered.", connName);
}

It an error message even when the operation succeeded (i.e., error is null).

It should include if (error != null) condition, like in the same class in another method.

Issue Links

• links to: GitHub Pull Request #7648